feat: error handling ux improvements #162

denviljclarke · 2024-11-22T08:59:06Z

Description

The PR adds some validation and improved messaging. I just added an error message for missing quote in the case of no other error. We could refactor to get the actual error but more often than not missing quote errors are because missing rates so I've just added a message to reflect this

Other changes

Increased the refetch interval of the swap quote by two seconds.
Add debouncing to validation logic to prevent excessive SDK calls and heavy computations on each keystroke

Tested

Swapped and tried to trigger errors on the preview deployment

Related issues

Fixes

Checklist before requesting a review

I have performed a self-review of my own code
The PR title follows the [conventions](https://www.notion.so/Git-Branching-and-Commit-Message-Conventions-

vercel · 2024-11-22T08:59:22Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mento-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 8, 2025 5:36pm

Andrew718PLTS · 2024-12-04T11:58:40Z

@nvtaveras Here are some issue found during testing:

Doesn't handle a case when no wallet connected and put a large number (e.g from the bug ticket: 7478773923223123234925). I think it should not change state to the grey continue button and after to the red with connect wallet text. One of them would be nice:
(I left a short video below due to GitHub restrictions)
It looks like validation with the grey continue button state after making some actions works fine BUT, I can't get my loadded balances for tokens after wallet connection - do you have this opportunity on vercel link?

Andrew718PLTS · 2024-12-04T11:59:00Z

Screen.Recording.2024-12-04.at.12.50.04.mov

src/features/swap/SwapForm.tsx

Andrew718PLTS · 2024-12-04T12:19:57Z

Still can proceed with a larger amount than balance (reproduced with CELO that equals 20 with 747877392322312323492566622277023 amount).
It breaks the page on the Confirm Swap state

Andrew718PLTS · 2024-12-27T11:54:18Z

Bug-fix list related to this ticket:

Doesn't handle a case when no wallet is connected and puts a large number (e.g., from the bug ticket: 7478773923223123234925)
Incorrect calculation of a larger amount than the balance with more than 22 digits and proceeding to Confirm state
The Confirm Swap page is corrupted when there are more than 22 numbers
The "Balance still loading" state for a button is stuck when any amount field is not changing (applied dynamical button on balance loading)
Missing specified toast errors on too large amounts
'Trading temporarily paused' handled for 'no valid median' and 'trading suspended' cases and moved to the toast message

refactor: cleanup chore: cleanup chore: cleanup refactor: cleanup fix: cleanup

…ned if

…nfirm state

…d types, shortened file

…same for 'no valid median' case

RyRy79261

Couldn't find functional faults, I would prefer the truncation just done with CSS & the variations managed by CVA but this should be a more uniform change if done.

Within scope, this PR seems fine

nvtaveras · 2025-01-09T15:01:35Z

src/features/swap/useSwapQuote.ts

+  { fromTokenSymbol, toTokenSymbol }: IGetToastErrorOptions = {}
+): string {
+  switch (true) {
+    case swapErrorMessage.includes(`overflow x1y1`):


What's the full error message that come from this error? Wondering if there's anything better we could use. Is it different from the one below, can't create fixidity number larger than

Here are the complete error messages regarding entering an too large number in the fields:
swap-out: overflow x1y1 * fixed1 detected
swap-in: can't create fixidity number larger than maxNewFixed()

nvtaveras · 2025-01-09T15:02:59Z

@Andrew718PLTS once I enter a large number 7478773923223123234925 without a wallet connected, it takes ~5 seconds to show the error message saying that the amount is too large. Why is that the case?

Andrew718PLTS · 2025-01-10T11:54:40Z

@Andrew718PLTS once I enter a large number 7478773923223123234925 without a wallet connected, it takes ~5 seconds to show the error message saying that the amount is too large. Why is that the case?

Previously, the calculation has not been correctly working when entering >=22 (e.g., 7478773923223123234925 -> 7.479)
It works the same way when a wallet is connected. If the getAmountOut or getAmountIn methods throw an error with the declared message, it shows an error toast with the specified message, depending on the method's error message.

denviljclarke force-pushed the fix/swap-validation branch from 21db863 to 19fc48b Compare November 22, 2024 09:08

vercel bot deployed to Preview November 22, 2024 09:10 View deployment

vercel bot deployed to Preview November 22, 2024 09:12 View deployment

vercel bot had a problem deploying to Preview November 22, 2024 09:43 Failure

denviljclarke force-pushed the fix/swap-validation branch from 55f85f9 to 686b3ac Compare November 22, 2024 09:49

vercel bot deployed to Preview November 22, 2024 09:51 View deployment

chapati23 assigned nvtaveras Dec 3, 2024

Andrew718PLTS reviewed Dec 4, 2024

View reviewed changes

src/features/swap/SwapForm.tsx Outdated Show resolved Hide resolved

Andrew718PLTS reviewed Dec 4, 2024

View reviewed changes

src/features/swap/SwapForm.tsx Outdated Show resolved Hide resolved

Andrew718PLTS reviewed Dec 4, 2024

View reviewed changes

src/features/swap/SwapForm.tsx Outdated Show resolved Hide resolved

bayological force-pushed the dev branch 2 times, most recently from c3f77c8 to 37676a5 Compare December 17, 2024 14:09

Andrew718PLTS force-pushed the fix/swap-validation branch from 686b3ac to 3dc2bb1 Compare December 23, 2024 14:32

vercel bot deployed to Preview December 23, 2024 14:34 View deployment

Andrew718PLTS force-pushed the fix/swap-validation branch from 51b6fe6 to 0eab54d Compare December 27, 2024 11:05

vercel bot deployed to Preview December 27, 2024 11:07 View deployment

vercel bot deployed to Preview December 27, 2024 20:10 View deployment

Andrew718PLTS force-pushed the fix/swap-validation branch from 99b0868 to 97df6ec Compare December 27, 2024 21:12

vercel bot deployed to Preview December 27, 2024 21:14 View deployment

denviljclarke and others added 3 commits January 7, 2025 23:09

feat: add validation & error handling ux improvements

0d9c28a

refactor: cleanup chore: cleanup chore: cleanup refactor: cleanup fix: cleanup

Fix: 'Connect Wallet' state on entering any values, naming and shorte…

00876ef

…ned if

Fix: Added and used tooltip for truncated amounts

a9e1d8d

Andrew718PLTS force-pushed the fix/swap-validation branch from 97df6ec to a9e1d8d Compare January 7, 2025 22:09

vercel bot deployed to Preview January 7, 2025 22:11 View deployment

Fix: Incorrect calculation amount over 22 digits and proceeding to co…

5f7372e

…nfirm state

Fix: Specified toast errors on too large amounts and added types

90599c1

vercel bot deployed to Preview January 8, 2025 00:07 View deployment

Fix: Made 'balance still loading' state dynamical for button

c75dda1

Andrew718PLTS force-pushed the fix/swap-validation branch from 1a4936a to c75dda1 Compare January 8, 2025 00:29

vercel bot deployed to Preview January 8, 2025 00:31 View deployment

Andrew718PLTS assigned Andrew718PLTS and unassigned nvtaveras Jan 8, 2025

Andrew718PLTS requested review from nvtaveras, RyRy79261 and philbow61 January 8, 2025 10:36

vercel bot deployed to Preview January 8, 2025 10:57 View deployment

Refactor: Used existing method, created functions for styles, improve…

5c89313

…d types, shortened file

Andrew718PLTS force-pushed the fix/swap-validation branch from 6394666 to 5c89313 Compare January 8, 2025 11:02

vercel bot deployed to Preview January 8, 2025 11:04 View deployment

Andrew718PLTS marked this pull request as ready for review January 8, 2025 11:42

Fix: Moved 'trading suspended' handling to toast error and added the …

800b2f8

…same for 'no valid median' case

vercel bot deployed to Preview January 8, 2025 17:36 View deployment

RyRy79261 requested a review from Andrew718PLTS January 9, 2025 14:15

RyRy79261 approved these changes Jan 9, 2025

View reviewed changes

nvtaveras reviewed Jan 9, 2025

View reviewed changes

Andrew718PLTS requested a review from nvtaveras January 10, 2025 11:54

Andrew718PLTS changed the title ~~feat: add validation & error handling ux improvements~~ feat: error handling ux improvements Jan 13, 2025

Andrew718PLTS closed this Jan 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: error handling ux improvements #162

feat: error handling ux improvements #162

denviljclarke commented Nov 22, 2024 •

edited by Andrew718PLTS

Loading

vercel bot commented Nov 22, 2024 •

edited

Loading

Andrew718PLTS commented Dec 4, 2024 •

edited

Loading

Andrew718PLTS commented Dec 4, 2024

Andrew718PLTS commented Dec 4, 2024

Andrew718PLTS commented Dec 27, 2024 •

edited

Loading

RyRy79261 left a comment

nvtaveras Jan 9, 2025 •

edited

Loading

Andrew718PLTS Jan 10, 2025

nvtaveras commented Jan 9, 2025

Andrew718PLTS commented Jan 10, 2025

feat: error handling ux improvements #162

feat: error handling ux improvements #162

Conversation

denviljclarke commented Nov 22, 2024 • edited by Andrew718PLTS Loading

Description

Other changes

Tested

Related issues

Checklist before requesting a review

vercel bot commented Nov 22, 2024 • edited Loading

Andrew718PLTS commented Dec 4, 2024 • edited Loading

Andrew718PLTS commented Dec 4, 2024

Andrew718PLTS commented Dec 4, 2024

Andrew718PLTS commented Dec 27, 2024 • edited Loading

RyRy79261 left a comment

Choose a reason for hiding this comment

nvtaveras Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Andrew718PLTS Jan 10, 2025

Choose a reason for hiding this comment

nvtaveras commented Jan 9, 2025

Andrew718PLTS commented Jan 10, 2025

denviljclarke commented Nov 22, 2024 •

edited by Andrew718PLTS

Loading

vercel bot commented Nov 22, 2024 •

edited

Loading

Andrew718PLTS commented Dec 4, 2024 •

edited

Loading

Andrew718PLTS commented Dec 27, 2024 •

edited

Loading

nvtaveras Jan 9, 2025 •

edited

Loading