Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer had same z-index as <main> and was covering the token dropdown on small screens #134

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

chapati23
Copy link
Contributor

  1. Check Markus' video on discord for reproduction https://discord.com/channels/966739027782955068/1065941733260660777/1255081871612575744
  2. Reproduce on app.mento.org by making your browser window small enough for the footer to overlap with the token dropdown of the "To:" dropdown
  3. See that you can't click the elements that overlap with the footer
  4. Check this branch's environment URL and see that the problem is fixed

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mento-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 9:50am

Copy link
Contributor

@denviljclarke denviljclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@chapati23 chapati23 merged commit 27ecf9e into main Jun 25, 2024
7 checks passed
@chapati23 chapati23 deleted the fix/footer-covering-token-dropdown branch June 25, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants