Feat governance gas tests #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baroooo
requested review from
a team,
bowd and
denviljclarke
and removed request for
a team and
bowd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates new fork tests checking the gas usage of governance actions.
We want to test if the rising number of locks causes any DoS for governance or locking.
Setting up the state for this test is quite slow on testnets and also that would not add any benefit imo thats why they are ran only on Celo.
Upper gas limits are decided considering the base gas usage of the actions
Other changes
Test accounts approves Locking contract for unlimited amount of mento transfers
Related issues