Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced npm install with bun i #135

Merged
merged 2 commits into from
Oct 31, 2024
Merged

replaced npm install with bun i #135

merged 2 commits into from
Oct 31, 2024

Conversation

Dedsec933
Copy link
Contributor

Pull Request for Memfree

Description

Replace NPM install with bun i for setting up test cases.

Related Issue

If this pull request addresses an issue, please link to it here. For example:
-Fixes #114

Changes Made

  • Added new feature
  • Fixed a bug
  • Updated documentation
  • Other (please specify)
  • Replace NPM install with bun i for setting up test cases

How to Test

Please describe the steps to test the changes made in this pull request. Include any specific commands or configurations needed.

  1. Step 1
  2. Step 2
  3. Step 3

Screenshots (if applicable)

If your changes include visual modifications, please add screenshots to help reviewers understand the changes.

Checklist

  • I have read the contributing guidelines
  • I have followed the code style guidelines
  • My code is tested and works as expected
  • I have updated the documentation (if necessary)

Additional Information

Please provide any additional information that may be helpful for the reviewers.

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Riyan-Mo
Copy link
Contributor

@ahaapple But using npm to install dependencies gives error. So I guess that's why he suggesting to use bun to install dependencies. This is the error that I encountered.
image

@ahaapple
Copy link
Contributor

@Riyan-Mo if so ,we could only use bun. but would better also use bun when run test bun run test, which is consistent.

@Riyan-Mo
Copy link
Contributor

@ahaapple Yes it would be consistent.

@Dedsec933
Copy link
Contributor Author

@ahaapple i have made the necessary changes

@ahaapple ahaapple merged commit d580134 into memfreeme:main Oct 31, 2024
2 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation Update]: Replace NPM install with bun i for setting up test cases.
3 participants