Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(use-copy-clipboard): add timer cleanup #116

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

twlite
Copy link
Contributor

@twlite twlite commented Oct 30, 2024

Pull Request for Memfree

Description

The use-copy-clipboard hook does not provide a cleanup function for setTimeout which can cause weird issues. This PR addresses that and correctly cleans up the timer.

Related Issue

N/A

Changes Made

  • Added new feature
  • Fixed a bug
  • Updated documentation
  • Other (please specify)

Checklist

  • I have read the contributing guidelines
  • I have followed the code style guidelines
  • My code is tested and works as expected
  • I have updated the documentation (if necessary)

Additional Information

Please provide any additional information that may be helpful for the reviewers.

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@ahaapple ahaapple merged commit 6362629 into memfreeme:main Oct 30, 2024
3 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants