refactor(open-customer-portal): remove redundant error handling (#123)

memfreeme · Oct 30, 2024 · d7acedd · d7acedd
1 parent 6201425
commit d7acedd
Showing 1 changed file with 12 additions and 18 deletions.
diff --git a/frontend/actions/open-customer-portal.ts b/frontend/actions/open-customer-portal.ts
@@ -14,26 +14,20 @@ export type responseAction = {
 const billingUrl = absoluteUrl('/');
 
 export async function openCustomerPortal(userStripeId: string): Promise<responseAction> {
-    let redirectUrl: string = '';
+    const session = await auth();
 
-    try {
-        const session = await auth();
-
-        if (!session?.user || !session?.user.email) {
-            throw new Error('Unauthorized');
-        }
+    if (!session?.user?.email) {
+        throw new Error('Unauthorized');
+    }
 
-        if (userStripeId) {
-            const stripeSession = await stripe.billingPortal.sessions.create({
-                customer: userStripeId,
-                return_url: billingUrl,
-            });
+    if (userStripeId) {
+        const stripeSession = await stripe.billingPortal.sessions.create({
+            customer: userStripeId,
+            return_url: billingUrl,
+        });
 
-            redirectUrl = stripeSession.url as string;
-        }
-    } catch (error) {
-        throw new Error('Failed to generate user stripe session');
+        redirect(stripeSession.url as string);
     }
-
-    redirect(redirectUrl);
+    
+    throw new Error('Failed to generate user stripe session');
 }