Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to disable asynchronous memory addition in completio… #2124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lfcunha07
Copy link

@lfcunha07 lfcunha07 commented Jan 7, 2025

Description

This change introduces an option to disable asynchronous memory addition in the completion.create method. This new feature allows developers to control memory behavior during the conversation, enabling synchronous memory addition for more predictable and controlled operation in specific use cases.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

This feature was tested by toggling the new option and observing whether memory addition occurs synchronously during the completion process. All tests passed with the new flag both enabled and disabled, showing consistent behavior across different scenarios.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2025

CLA assistant check
All committers have signed the CLA.

@lfcunha07 lfcunha07 force-pushed the feature/optional-sync-memory-completion branch from 9095b35 to a7f2fb3 Compare January 8, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants