Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow developers to mark stream schema and settings fields as deprecated #2830

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 15, 2025

Closes #2116


📚 Documentation preview 📚: https://meltano-sdk--2830.org.readthedocs.build/en/2830/

@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 15, 2025 21:20
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #2830 will not alter performance

Comparing 2116-feat-support-using-json-schemas-deprecated-keyword-to-mark-deprecated-settings (f1dd781) with main (b3610ca)

Summary

✅ 7 untouched benchmarks

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (b3610ca) to head (f1dd781).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2830   +/-   ##
=======================================
  Coverage   91.30%   91.31%           
=======================================
  Files          62       62           
  Lines        5201     5206    +5     
  Branches      671      672    +1     
=======================================
+ Hits         4749     4754    +5     
  Misses        319      319           
  Partials      133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon changed the title feat: Allow developers to mark schema fields as deprecated feat: Allow developers to mark stream schema and settings fields as deprecated Jan 15, 2025
@edgarrmondragon edgarrmondragon merged commit b4c6ecc into main Jan 15, 2025
37 checks passed
@edgarrmondragon edgarrmondragon deleted the 2116-feat-support-using-json-schemas-deprecated-keyword-to-mark-deprecated-settings branch January 15, 2025 21:27
@edgarrmondragon edgarrmondragon added this to the v0.44 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support using JSON Schema's deprecated keyword to mark deprecated settings
1 participant