Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(targets): Support a x-sql-datatype JSON Schema annotation to let targets customize SQL type handling #2829

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 15, 2025

@edgarrmondragon edgarrmondragon added the Type/Target Singer targets label Jan 15, 2025
@edgarrmondragon edgarrmondragon self-assigned this Jan 15, 2025
@edgarrmondragon edgarrmondragon added the SQL Support for SQL taps and targets label Jan 15, 2025
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #2829 will not alter performance

Comparing x-sql-datatype (bddbfe4) with main (8638b07)

Summary

✅ 7 untouched benchmarks

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (8638b07) to head (bddbfe4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2829      +/-   ##
==========================================
+ Coverage   91.29%   91.30%   +0.01%     
==========================================
  Files          62       62              
  Lines        5190     5201      +11     
  Branches      669      671       +2     
==========================================
+ Hits         4738     4749      +11     
  Misses        319      319              
  Partials      133      133              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon changed the title feat(targets): Support a x-sql-datatype annotation to let targets customize SQL type handling feat(targets): Support a x-sql-datatype JSON Schema annotation to let targets customize SQL type handling Jan 15, 2025
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 15, 2025 20:58
@edgarrmondragon edgarrmondragon requested review from a team as code owners January 15, 2025 20:59
@edgarrmondragon edgarrmondragon added this to the v0.44 milestone Jan 15, 2025
@edgarrmondragon edgarrmondragon merged commit b3610ca into main Jan 15, 2025
36 checks passed
@edgarrmondragon edgarrmondragon deleted the x-sql-datatype branch January 15, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL Support for SQL taps and targets Type/Target Singer targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(taps): Support declaring arbitrary SQLAlchemy type instances in SQL tap schemas
1 participant