refactor: Rename setting activate_version to `process_activate_vers…

…ion_messages` (#2805)
meltano · Dec 10, 2024 · 95a84d0 · 95a84d0
1 parent fd494db
commit 95a84d0
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 6 deletions.
diff --git a/cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/.pre-commit-config.yaml b/cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/.pre-commit-config.yaml
@@ -24,7 +24,7 @@ repos:
   - id: check-github-workflows
 
 - repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: v0.8.1
+  rev: v0.8.2
   hooks:
   - id: ruff
     args: [--fix, --exit-non-zero-on-fix, --show-fixes]

diff --git a/cookiecutter/tap-template/{{cookiecutter.tap_id}}/.pre-commit-config.yaml b/cookiecutter/tap-template/{{cookiecutter.tap_id}}/.pre-commit-config.yaml
@@ -24,7 +24,7 @@ repos:
   - id: check-github-workflows
 
 - repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: v0.8.1
+  rev: v0.8.2
   hooks:
   - id: ruff
     args: [--fix, --exit-non-zero-on-fix, --show-fixes]

diff --git a/cookiecutter/target-template/{{cookiecutter.target_id}}/.pre-commit-config.yaml b/cookiecutter/target-template/{{cookiecutter.target_id}}/.pre-commit-config.yaml
@@ -24,7 +24,7 @@ repos:
   - id: check-github-workflows
 
 - repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: v0.8.1
+  rev: v0.8.2
   hooks:
   - id: ruff
     args: [--fix, --exit-non-zero-on-fix, --show-fixes]

diff --git a/singer_sdk/helpers/capabilities.py b/singer_sdk/helpers/capabilities.py
@@ -146,7 +146,7 @@
 ).to_dict()
 ACTIVATE_VERSION_CONFIG = PropertiesList(
     Property(
-        "activate_version",
+        "process_activate_version_messages",
         BooleanType,
         default=True,
         title="Process `ACTIVATE_VERSION` messages",

diff --git a/singer_sdk/sinks/core.py b/singer_sdk/sinks/core.py
@@ -406,7 +406,7 @@ def process_activate_version_messages(self) -> bool:
         Returns:
             True if activate version messages should be processed.
         """
-        return self.config.get("activate_version", True)
+        return self.config.get("process_activate_version_messages", True)
 
     @property
     def datetime_error_treatment(self) -> DatetimeErrorTreatmentEnum:

diff --git a/tests/samples/test_target_sqlite.py b/tests/samples/test_target_sqlite.py
@@ -79,7 +79,12 @@ def sqlite_sample_target_hard_delete(sqlite_target_test_config):
 @pytest.fixture
 def sqlite_sample_target_no_activate_version(sqlite_target_test_config):
     """Get a sample target object with hard_delete disabled."""
-    return SQLiteTarget(config={**sqlite_target_test_config, "activate_version": False})
+    return SQLiteTarget(
+        config={
+            **sqlite_target_test_config,
+            "process_activate_version_messages": False,
+        }
+    )
 
 
 @pytest.fixture