Use cross justify to expand the trigger window

melody-rs · Jul 1, 2024 · b0160a4 · b0160a4
1 parent 765cb6c
commit b0160a4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/crates/components/src/lib.rs b/crates/components/src/lib.rs
@@ -98,12 +98,14 @@ impl<'e, T: ToString + PartialEq + strum::IntoEnumIterator> egui::Widget for Enu
         let mut changed = false;
         let mut response = ui
             .vertical(|ui| {
-                for variant in T::iter() {
-                    let text = variant.to_string();
-                    if ui.radio_value(self.current_value, variant, text).changed() {
-                        changed = true;
+                ui.with_cross_justify(|ui| {
+                    for variant in T::iter() {
+                        let text = variant.to_string();
+                        if ui.radio_value(self.current_value, variant, text).changed() {
+                            changed = true;
+                        }
                     }
-                }
+                });
             })
             .response;
         if changed {

diff --git a/crates/ui/src/windows/event_edit.rs b/crates/ui/src/windows/event_edit.rs
@@ -183,7 +183,7 @@ impl luminol_core::Window for Window {
                             );
                             ui.label("is ON");
                             // ensure we expand to fit the side panel
-                            ui.add_space(ui.available_width());
+                            ui.add_space(ui.available_width()); // cross justify doesn't seem to be able to replace this?
                         });
                     });
 
@@ -257,7 +257,7 @@ impl luminol_core::Window for Window {
                 egui::TopBottomPanel::bottom(id_source.with("bottom_panel")).show_inside(
                     ui,
                     |ui| {
-                        ui.add_space(ui.style().spacing.item_spacing.y);
+                        ui.add_space(1.0); // it still looks a little squished, even with this. how can we fix this?
                         luminol_components::close_options_ui(ui, open, &mut needs_save)
                     },
                 );