Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLC-162: Re-added missing reports: Total Chief Complaints & Total Dental #15

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Ruhanga
Copy link
Member

@Ruhanga Ruhanga commented Nov 1, 2024

@suruchee suruchee requested a review from rbuisson November 4, 2024 07:52
Comment on lines +71 to +73
"rowGroups": [ "Concept Name", "value" ],
"columnGroups": [ "Location Name" , "Adult Child" , "Gender" ],
"distinctGroups": [ "Obs Id" ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format is unusual (w/ thoses spaces before and after array member).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just imported the report as it was, and it closely resembles the format of the other reports in this JSON file. I suggest adding the JSON formatting in a separate commit.

Comment on lines +91 to +93
"rowGroups": [ "Concept Name" , "value" ],
"columnGroups": [ "Location Name" ,"Adult Child", "Gender" ],
"distinctGroups": [ "Obs Id" ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just imported the report as it was, and it closely resembles the format of the other reports in this JSON file. I suggest adding the JSON formatting in a separate commit.

"type": "observations",
"config": {
"conceptNamesToFilter":["Cambodia_Small Dental Surgery Set", "Cambodia_Teeth Extracted","Cambodia_Teeth Filled","Coded Diagnosis","Non-coded Diagnosis", "Offline Diagnosis", "Non-coded Offline Diagnosis"],
"conceptValuesToFilter": ["","Supernumerary teeth","Embedded and impacted teeth","Dental caries","Diseases of hard teeth tissue, other","Cracked tooth","Acute gingivitis","Chronic gingivitis","Dental Abscess","Dental problem","Oral diseases, other","Oral ulcer, other forms of stomatitis","Stomatitis","CAMBODIA_Tooth 11","CAMBODIA_Tooth 12","CAMBODIA_Tooth 13","CAMBODIA_Tooth 14","CAMBODIA_Tooth 15","CAMBODIA_Tooth 16","CAMBODIA_Tooth 17","CAMBODIA_Tooth 18","CAMBODIA_Tooth 21","CAMBODIA_Tooth 22","CAMBODIA_Tooth 23","CAMBODIA_Tooth 24","CAMBODIA_Tooth 25","CAMBODIA_Tooth 26","CAMBODIA_Tooth 27","CAMBODIA_Tooth 28","CAMBODIA_Tooth 31","CAMBODIA_Tooth 32","CAMBODIA_Tooth 33","CAMBODIA_Tooth 34","CAMBODIA_Tooth 35","CAMBODIA_Tooth 36","CAMBODIA_Tooth 37","CAMBODIA_Tooth 38","CAMBODIA_Tooth 41","CAMBODIA_Tooth 42","CAMBODIA_Tooth 43","CAMBODIA_Tooth 44","CAMBODIA_Tooth 45","CAMBODIA_Tooth 46","CAMBODIA_Tooth 47","CAMBODIA_Tooth 48","CAMBODIA_Tooth 51","CAMBODIA_Tooth 52","CAMBODIA_Tooth 53","CAMBODIA_Tooth 54","CAMBODIA_Tooth 55","CAMBODIA_Tooth 61","CAMBODIA_Tooth 62","CAMBODIA_Tooth 63","CAMBODIA_Tooth 64","CAMBODIA_Tooth 65","CAMBODIA_Tooth 71","CAMBODIA_Tooth 72","CAMBODIA_Tooth 73","CAMBODIA_Tooth 74","CAMBODIA_Tooth 75","CAMBODIA_Tooth 81","CAMBODIA_Tooth 82","CAMBODIA_Tooth 83","CAMBODIA_Tooth 84","CAMBODIA_Tooth 85"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

["" is this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for displaying aggregated data. This follows the previous format, so I haven't introduced a new report.

@Ruhanga Ruhanga changed the title TLC-162: added missing reports: Total Chief Complaints & Total Dental TLC-162: Re-added missing reports: Total Chief Complaints & Total Dental Nov 4, 2024
@Ruhanga Ruhanga merged commit 0282d91 into mekomsolutions:main Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants