Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proportion estimation for NA values #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yoda-vid
Copy link

@yoda-vid yoda-vid commented Jun 9, 2022

Thanks for your deconvolution software. I encountered an error during proportion estimation where some NA common genes would be found for some bulk cells. Here is an example stacktrace:

WNNLS Converged at iteration 2
ACACACTTTCTACACG-1_10 has common genes 70 ...
WNNLS Converged at iteration 3
ACACATGATCAAATCT-1_10 has common genes NA ...
ERROR [2022-06-09 15:40:26] NA/NaN/Inf in foreign function call (arg 5)

Compact call stack:
  1 #7: source(parsed$script)
  2 deconvolve_scdc.R#13: tryCatchLog::tryCatchLog({
  3 deconvolve_scdc.R#65: SCDC::SCDC_prop(bulk.eset = eset.integ, sc.eset = eset.ref, sample = "sample", ct.varname = "Class", ct.sub = as.character(unique(eset.ref$Class)))
  4 Deconvolution.R#606: nnls::nnls(A = basis.mvw.temp, b = xbulk.temp)


Error in nnls::nnls(A = basis.mvw.temp, b = xbulk.temp) : 
  NA/NaN/Inf in foreign function call (arg 5)

I was able to work around it by skipping these cells and recording their indices to remove the barcodes. I am not sure if this is the best solution though and wanted to share it here in case it is useful or if there is a better approach.

Might be related to #17, #18.

yoda-vid added 2 commits June 9, 2022 15:02
Skip NA common genes from the bulk sample by recording indices where NA common genes are found and removing the corresponding column names from the output.
Only remove indices if they exist, which avoids attempting to index by NULL and removing all `yobs` values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant