Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kumuluzee implementation support #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mickaelbaron
Copy link

@mickaelbaron mickaelbaron commented Jul 29, 2019

Hi,

I propose to you this PR to add Kumuluzee implementation support for your project.

I don't have impacted the README.md file since I want to you give me your opinion about this improvement.

Note, I need to copy the beans.xml file into the src/main/resources/META_INF because a Kumuluzee needs to be packaged into a Jar file. In fact, I don't know OpenLiberty implementation and how it's possible to switch War to Jar packaging file.

To compile with Kumuluzee implementation

mvn clean package -P kumuluzee

To run

PORT=3000 java -jar target/qrcreator.jar

To test: http://localhost:3000/index.html

Thx for your advise

Mickael

@mehmandarov
Copy link
Owner

Thanks, @mickaelbaron! I will definitely look into how to incorporate this into the existing code. I appreciate you taking time to do this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants