Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I propose to you this PR to add Kumuluzee implementation support for your project.
I don't have impacted the README.md file since I want to you give me your opinion about this improvement.
Note, I need to copy the beans.xml file into the src/main/resources/META_INF because a Kumuluzee needs to be packaged into a Jar file. In fact, I don't know OpenLiberty implementation and how it's possible to switch War to Jar packaging file.
To compile with Kumuluzee implementation
mvn clean package -P kumuluzee
To run
PORT=3000 java -jar target/qrcreator.jar
To test: http://localhost:3000/index.html
Thx for your advise
Mickael