Missing origin attr added per 0.11 xsd #19
Conversation
| @@ -49,6 +50,8 @@ def from_element(cls, element): | |||
| user = User.from_element(sub_element) | |||
| elif tag == "minor": | |||
| minor = True | |||
| elif tag == "origin": | |||
| origin = sub_element.text | |||
There was a problem hiding this comment.
We'll need to add "origin" to the mwtypes.Revision model too and make sure it gets set.
|
Sorry for the late review! Thanks for the PR. This looks good but we'll need to do some work on the mwtypes library first to make this work. If we've officially switched to the new format, it looks like a bunch of pending work can get merged! I'll take a look at that over the next couple days so we can get this incorporated. |
|
This is relevant but doesn't include "origin" mediawiki-utilities/python-mwtypes#5 |
|
Yes, if I understand correctly it is already written in the Content_Type class but not yet in the Revision_Type class (python-mwtypes/tree/updates_schema_0.11). I've hacked this PR to make it work in a project where I use the updates_schema_0.11 branch from that project with no change (python-mwtypes/tree/updates_schema_0.11) and only on a Content dump of a Mediawiki (no revisions). That's probably why. I'm still interested in the 0.11 branches of both projects btw ! |
|
OK both of these are in PyPi. Let me know how it goes! |
|
Thank you SO MUCH! Did you fix this too? #20 Anyway thanks! |
Missing origin attr added per 0.11 xsd, otherwise mwtypes breaks.