Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): Add/Fix interfaces field of at-rules #856

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

skyclouds2001
Copy link
Contributor

Description

Motivation

Additional details

see also discussion about interfaces field at #853 (comment)

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 25, 2024 17:00
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 25, 2024 17:00
@skyclouds2001 skyclouds2001 requested review from bsmth and removed request for a team December 25, 2024 17:00
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks a lot. Maybe we need a docs change to accompany this for clarification on inheritance.

@skyclouds2001
Copy link
Contributor Author

Makes sense, thanks a lot. Maybe we need a docs change to accompany this for clarification on inheritance.

Add a sentence indicating that inherit interfaces should not be included.

css/at-rules.md Outdated Show resolved Hide resolved
@bsmth
Copy link
Member

bsmth commented Jan 15, 2025

Thank you!

@bsmth bsmth merged commit 20f0bab into mdn:main Jan 15, 2025
3 checks passed
@skyclouds2001 skyclouds2001 deleted the interfaces_at-rules branch January 15, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants