Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows/release): trigger deployment after publish #25661

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 15, 2025

Summary

Ensures that the just-released BCD version is deployed on MDN.

Test results and supporting details

We were dispatching the bcd_release event as soon as the GitHub release was created, but at that point, the npm package was not yet published, so mdn/bcd-utils used the previous BCD version for deployment, causing BCD changes in a release to only show up delayed with the next release.

Related issues

Fixes mdn/bcd-utils#133.

@caugner caugner requested a review from Elchi3 January 15, 2025 16:43
@github-actions github-actions bot added infra Infrastructure issues (npm, GitHub Actions, releases) of this project size:m [PR only] 25-100 LoC changed labels Jan 15, 2025
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really test this but from glancing over it, it makes sense. Thank you, Claas! 👍

@Elchi3 Elchi3 merged commit 14cb707 into main Jan 16, 2025
10 checks passed
@Elchi3 Elchi3 deleted the trigger-bcd-deployment-after-publish branch January 16, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infrastructure issues (npm, GitHub Actions, releases) of this project size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API deployment uses previous BCD version
2 participants