-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tokenizer problem with commas inside NMR peaks #18
base: master
Are you sure you want to change the base?
Conversation
Sorry I've taken so long to review this - there's some great stuff here. But could you create separate branches for each individual change so they can have separate, more focused Pull Requests? That way you can also continue developing on your Some help documentation here: |
Ok, I'll do that |
Hello,
I found a problem while you are reading NMR peaks when you have no whitespace between two elements, like this:
9.73 (s,1H)
This is parsed as a peak with an assignment instead of a peak with a multiplicity and a number, I also add some cases for other contexts when you have some coupling units.