Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedro/analytical/by element #1243

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Pedro/analytical/by element #1243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
88996e2
Delete previous components
pedrocortesark Dec 9, 2024
f97e07d
Added new component to create physical elements from analytical ones
pedrocortesark Dec 11, 2024
f75a020
Created cluster component and renaming
pedrocortesark Dec 11, 2024
944ea82
Minor changes
pedrocortesark Dec 11, 2024
2ae272d
Tolerace error in Revit when units are mm
pedrocortesark Dec 12, 2024
76aa1e4
Upda ClusterAnalytical component
pedrocortesark Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 47 additions & 67 deletions ...Structure/AddAnalyticalElement-Element.cs → ...e/AddAnalyticalElement-PhysicalElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System;
using System.Linq;
using Autodesk.Revit.DB;
using Autodesk.Revit.DB.Structure;
using Grasshopper.Kernel;
using Rhino.Geometry;
Expand All @@ -20,19 +21,19 @@ namespace RhinoInside.Revit.GH.Components.Structure
#endif

[ComponentVersion(introduced: "1.27"), ComponentRevitAPIVersion(min: "2023.0")]
public class AddAnalyticalElementByElement : BaseAnalyticalComponent
public class AddAnalyticalElementByPhysicalElement : BaseAnalyticalComponent
{
public override Guid ComponentGuid => new Guid("AC26C810-2043-4666-B16E-8484D9DCF7DE");
#if REVIT_2023
public override GH_Exposure Exposure => GH_Exposure.tertiary;
public override GH_Exposure Exposure => GH_Exposure.quarternary;
#else
public override GH_Exposure Exposure => GH_Exposure.hidden;
#endif
public AddAnalyticalElementByElement() : base
public AddAnalyticalElementByPhysicalElement() : base
(
name: "Add Analytical Element (Element)",
name: "Add Analytical Element (Physical Element)",
nickname: "AE-Element",
description: "Given an element, it extract its analytical element to the active Revit document",
description: "Given a physical element, it extracts its analytical element to the active Revit document",
category: "Revit",
subCategory: "Structure"
)
Expand All @@ -55,9 +56,9 @@ public AddAnalyticalElementByElement() : base
(
new Parameters.GraphicalElement()
{
Name = "Element",
NickName = "E",
Description = "Graphical element",
Name = "Physical Element",
NickName = "P",
Description = "Physical element",
Access = GH_ParamAccess.item
}
),
Expand All @@ -68,66 +69,29 @@ public AddAnalyticalElementByElement() : base
{
new ParamDefinition
(
new Parameters.AnalyticalMember()
{
Name = _AnalyticalMemberBeam_,
NickName = "AM-Beam",
Description = $"Output {_AnalyticalMemberBeam_}",
}
),
new ParamDefinition
(
new Parameters.AnalyticalMember()
{
Name = _AnalyticalMemberColumn_,
NickName = "AM-Column",
Description = $"Output {_AnalyticalMemberColumn_}",
}
),
new ParamDefinition
(
new Parameters.AnalyticalMember()
{
Name = _AnalyticalMemberBrace_,
NickName = "AM-Brace",
Description = $"Output {_AnalyticalMemberBrace_}",
}
),
new ParamDefinition
(
new Parameters.AnalyticalPanel()
{
Name = _AnalyticalPanelFloor_,
NickName = "AP-Floor",
Description = $"Output {_AnalyticalPanelFloor_}",
}
),
new ParamDefinition
(
new Parameters.AnalyticalPanel()
{
Name = _AnalyticalPanelWall_,
NickName = "AP-Wall",
Description = $"Output {_AnalyticalPanelWall_}",
}
new Parameters.AnalyticalElement()
{
Name = _AnalyticalElement_,
NickName = _AnalyticalElement_.Substring(0,1),
Description = $"Output {_AnalyticalElement_}",
}
)
};

const string _AnalyticalMemberBeam_ = "Analytical Member (Beam)";
const string _AnalyticalMemberColumn_ = "Analytical Member (Column)";
const string _AnalyticalMemberBrace_ = "Analytical Member (Brace)";
const string _AnalyticalPanelFloor_ = "Analytical Panel (Floor)";
const string _AnalyticalPanelWall_ = "Analytical Panel (Wall)";
const string _AnalyticalElement_ = "Analytical Element";

protected override void TrySolveInstance(IGH_DataAccess DA)
{
#if REVIT_2023
if (!Parameters.Document.TryGetDocumentOrCurrent(this, DA, "Document", out var doc) || !doc.IsValid) return;
if (!Params.GetData(DA, "Element", out Types.GraphicalElement element)) return;
if (!Params.GetData(DA, "Physical Element", out Types.GraphicalElement element)) return;

// Checking input
var tol = GeometryTolerance.Model;
Brep boundary = null;
var thickness = 0.0;
ElementId typeId = default;
ElementId materialId = default;
AnalyticalStructuralRole structuralRole = AnalyticalStructuralRole.Unset;
switch (element)
{
Expand All @@ -137,12 +101,18 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
{
case ARDB.Structure.StructuralType.Beam:
structuralRole = AnalyticalStructuralRole.StructuralRoleBeam;
typeId = member.Value.GetTypeId();
materialId = member.Value.StructuralMaterialId;
break;
case ARDB.Structure.StructuralType.Brace:
structuralRole = AnalyticalStructuralRole.StructuralRoleGirder;
typeId = member.Value.GetTypeId();
materialId = member.Value.StructuralMaterialId;
break;
case ARDB.Structure.StructuralType.Column:
structuralRole = AnalyticalStructuralRole.StructuralRoleColumn;
typeId = member.Value.GetTypeId();
materialId = member.Value.StructuralMaterialId;
break;
}

Expand All @@ -151,24 +121,26 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
case Types.Wall wall:
boundary = wall.TrimmedSurface;
structuralRole = AnalyticalStructuralRole.StructuralRoleWall;
thickness = wall.Value.Width;
break;

case Types.Floor floor:
boundary = floor.Sketch.TrimmedSurface;
structuralRole = AnalyticalStructuralRole.StructuralRoleFloor;
thickness = floor.Value.get_Parameter(BuiltInParameter.FLOOR_ATTR_THICKNESS_PARAM).AsDouble();
break;
}

// Compute
switch (structuralRole)
{
case AnalyticalStructuralRole.Unset:
this.AddRuntimeMessage(GH_RuntimeMessageLevel.Remark, $"Element with id {element.Id} is not supported for creating an analytical element");
this.AddRuntimeMessage(GH_RuntimeMessageLevel.Warning, $"Physical element is not supported for creating an analytical element: {element.Id}");
return;
case AnalyticalStructuralRole.StructuralRoleBeam:
ReconstructElement<ARDB_AnalyticalMember>
(
doc.Value, _AnalyticalMemberBeam_, analyticalMember =>
doc.Value, _AnalyticalElement_, analyticalMember =>
{
analyticalMember = Reconstruct
(
Expand All @@ -178,15 +150,17 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
);

analyticalMember.StructuralRole = structuralRole;
DA.SetData(_AnalyticalMemberBeam_, analyticalMember);
analyticalMember.SectionTypeId = typeId;
analyticalMember.MaterialId = materialId;
DA.SetData(_AnalyticalElement_, analyticalMember);
return analyticalMember;
}
);
break;
case AnalyticalStructuralRole.StructuralRoleColumn:
ReconstructElement<ARDB_AnalyticalMember>
(
doc.Value, _AnalyticalMemberColumn_, analyticalMember =>
doc.Value, _AnalyticalElement_, analyticalMember =>
{
analyticalMember = Reconstruct
(
Expand All @@ -196,15 +170,17 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
);

analyticalMember.StructuralRole = structuralRole;
DA.SetData(_AnalyticalMemberColumn_, analyticalMember);
analyticalMember.SectionTypeId = typeId;
analyticalMember.MaterialId = materialId;
DA.SetData(_AnalyticalElement_, analyticalMember);
return analyticalMember;
}
);
break;
case AnalyticalStructuralRole.StructuralRoleGirder:
ReconstructElement<ARDB_AnalyticalMember>
(
doc.Value, _AnalyticalMemberBrace_, analyticalMember =>
doc.Value, _AnalyticalElement_, analyticalMember =>
{
analyticalMember = Reconstruct
(
Expand All @@ -214,7 +190,9 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
);

analyticalMember.StructuralRole = structuralRole;
DA.SetData(_AnalyticalMemberBrace_, analyticalMember);
analyticalMember.SectionTypeId = typeId;
analyticalMember.MaterialId = materialId;
DA.SetData(_AnalyticalElement_, analyticalMember);
return analyticalMember;
}
);
Expand All @@ -223,7 +201,7 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
case AnalyticalStructuralRole.StructuralRoleFloor:
ReconstructElement<ARDB_AnalyticalPanel>
(
doc.Value, _AnalyticalPanelFloor_, analyticalPanel =>
doc.Value, _AnalyticalElement_, analyticalPanel =>
{
if (boundary.Faces.Count != 1)
throw new RuntimeArgumentException("Boundary", "Boundary surface should have only one face.", boundary);
Expand Down Expand Up @@ -277,15 +255,16 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
);

analyticalPanel.StructuralRole = structuralRole;
DA.SetData(_AnalyticalPanelFloor_, analyticalPanel);
analyticalPanel.Thickness = thickness;
DA.SetData(_AnalyticalElement_, analyticalPanel);
return analyticalPanel;
}
);
break;
case AnalyticalStructuralRole.StructuralRoleWall:
ReconstructElement<ARDB_AnalyticalPanel>
(
doc.Value, _AnalyticalPanelWall_, analyticalPanel =>
doc.Value, _AnalyticalElement_, analyticalPanel =>
{
if (boundary.Faces.Count != 1)
throw new RuntimeArgumentException("Boundary", "Boundary surface should have only one face.", boundary);
Expand Down Expand Up @@ -339,7 +318,8 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
);

analyticalPanel.StructuralRole = structuralRole;
DA.SetData(_AnalyticalPanelWall_, analyticalPanel);
analyticalPanel.Thickness = thickness;
DA.SetData(_AnalyticalElement_, analyticalPanel);
return analyticalPanel;
}
);
Expand Down
125 changes: 0 additions & 125 deletions src/RhinoInside.Revit.GH/Components/Structure/AddAnalyticalMember-Element.cs
View file
Open in desktop

This file was deleted.

Loading
Loading