Merge pull request #1207 from mcneel/1.26

Fix on `GeometryObject.GetBoundingBox` extension method.
mcneel · Nov 13, 2024 · c5b2588 · c5b2588
2 parents 73fb4a5 + 6866571
commit c5b2588
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/src/RhinoInside.Revit.External/DB/Extensions/GeometryObject.cs b/src/RhinoInside.Revit.External/DB/Extensions/GeometryObject.cs
@@ -669,6 +669,7 @@ public static BoundingBoxXYZ GetBoundingBox(this GeometryObject geometry, Transf
             else
             {
               var bbox = element.GetTransformed(coordSystem.Inverse).GetBoundingBox();
+              if (bbox.IsNegative()) bbox = BoundingBoxXYZExtension.Empty;
               bbox.Transform = coordSystem;
               return bbox;
             }
@@ -690,13 +691,15 @@ public static BoundingBoxXYZ GetBoundingBox(this GeometryObject geometry, Transf
             else
             {
               var bbox = instance.GetSymbolGeometry(coordSystem.Inverse * instance.Transform).GetBoundingBox();
+              if (bbox.IsNegative()) bbox = BoundingBoxXYZExtension.Empty;
               bbox.Transform = coordSystem;
               return bbox;
             }
           }
           else
           {
             var bbox = instance.SymbolGeometry.GetBoundingBox();
+            if (bbox.IsNegative()) bbox = BoundingBoxXYZExtension.Empty;
             bbox.Transform = instance.Transform;
             return bbox;
           }
@@ -744,11 +747,11 @@ public static BoundingBoxXYZ GetBoundingBox(this GeometryObject geometry, Transf
         {
           if (!solid.Faces.IsEmpty)
           {
+            var bbox = BoundingBoxXYZExtension.Empty;
             if (coordSystem is object)
             {
               if (accurateSolid)
               {
-                var bbox = BoundingBoxXYZExtension.Empty;
                 bbox.Transform = coordSystem;
 
                 foreach (Face face in solid.Faces)
@@ -761,7 +764,10 @@ public static BoundingBoxXYZ GetBoundingBox(this GeometryObject geometry, Transf
               {
                 using (var transformed = SolidUtils.CreateTransformed(solid, coordSystem.Inverse))
                 {
-                  var (min, max, transform, bounds) = transformed.GetBoundingBox();
+                  bbox = transformed.GetBoundingBox();
+                  if (bbox.IsNegative()) bbox = BoundingBoxXYZExtension.Empty;
+
+                  var (min, max, transform, bounds) = bbox;
                   var (minX, minY, minZ) = transform.OfPoint(min);
                   var (maxX, maxY, maxZ) = transform.OfPoint(max);
 
@@ -774,7 +780,10 @@ public static BoundingBoxXYZ GetBoundingBox(this GeometryObject geometry, Transf
                 }
               }
             }
-            return solid.GetBoundingBox();
+
+            bbox = solid.GetBoundingBox();
+            if (bbox.IsNegative()) bbox = BoundingBoxXYZExtension.Empty;
+            return bbox;
           }
         }
         break;

diff --git a/src/RhinoInside.Revit/AssemblyResolver.cs b/src/RhinoInside.Revit/AssemblyResolver.cs
@@ -544,15 +544,17 @@ static Assembly GetRequestingAssembly()
       int f = 0;
       for (; f < frames.Length; ++f)
       {
-        var frameAssembly = frames[f].GetMethod().DeclaringType.Assembly;
+        var method = frames[f].GetMethod();
+        var frameAssembly = method.DeclaringType?.Assembly ?? method.Module?.Assembly;
         if (frameAssembly != callingAssembly)
           break;
       }
 
       // Skip mscorlib
       for (; f < frames.Length; ++f)
       {
-        var frameAssembly = frames[f].GetMethod().DeclaringType.Assembly;
+        var method = frames[f].GetMethod();
+        var frameAssembly = method.DeclaringType?.Assembly ?? method.Module?.Assembly;
         if (frameAssembly != typeof(object).Assembly)
           return frameAssembly;
       }