Mix of fixes.

mcneel · Dec 17, 2024 · 1b1e4e9 · 1b1e4e9
1 parent f0a785f
commit 1b1e4e9
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 11 deletions.
diff --git a/src/RhinoInside.Revit.GH/Components/Structure/AddBoundaryConditions-Area.cs b/src/RhinoInside.Revit.GH/Components/Structure/AddBoundaryConditions-Area.cs
@@ -135,8 +135,6 @@ Types.GeometryFace surface
           Create(doc, surface),
           ExcludeUniqueProperties
         );
-
-        bConditions.Document.Regenerate();
       }
 
       return bConditions;

diff --git a/src/RhinoInside.Revit.GH/Components/Structure/AddBoundaryConditions-Line.cs b/src/RhinoInside.Revit.GH/Components/Structure/AddBoundaryConditions-Line.cs
@@ -124,8 +124,6 @@ Types.GeometryCurve curve
           Create(doc, curve),
           ExcludeUniqueProperties
         );
-
-        bConditions.Document.Regenerate();
       }
       return bConditions;
     }

diff --git a/src/RhinoInside.Revit.GH/Components/Structure/AddBoundaryConditions-Point.cs b/src/RhinoInside.Revit.GH/Components/Structure/AddBoundaryConditions-Point.cs
@@ -133,8 +133,6 @@ Types.GeometryPoint point
           Create(doc, point),
           ExcludeUniqueProperties
         );
-
-        bConditions.Document.Regenerate();
       }
       return bConditions;
     }

diff --git a/src/RhinoInside.Revit.GH/Components/Structure/AddModelElement-Analytical.cs b/src/RhinoInside.Revit.GH/Components/Structure/AddModelElement-Analytical.cs
@@ -106,7 +106,7 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
           (
             doc.Value, _ModelElement_, floor =>
             {
-              var tol = GeometryTolerance.Internal;
+              var tol = GeometryTolerance.Model;
               var panel = analyticalElement.Value as ARDB_AnalyticalPanel;
 
               if (panel.Thickness == 0.0)
@@ -129,15 +129,15 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
               var floorType = collector.
                 OfCategory(ARDB.BuiltInCategory.OST_Floors).
                 WhereElementIsElementType().
-                Where(t => Rhino.RhinoMath.EpsilonEquals
+                Where(t => GeometryTolerance.Internal.DefaultTolerance.Equals
                 (
                   t.get_Parameter(ARDB.BuiltInParameter.FLOOR_ATTR_DEFAULT_THICKNESS_PARAM).AsDouble(),
-                  panel.Thickness,
-                  tol.DefaultTolerance)
-                ).
+                  panel.Thickness
+                )).
                 Cast<ARDB.FloorType>().
                 FirstOrDefault();
 
+
               if (floorType is null)
                 throw new RuntimeException($"No floor type found with the same thickness as the analytical panel. {{{analyticalElement.Id}}}");
 

diff --git a/src/RhinoInside.Revit.GH/Types/GraphicalElement.cs b/src/RhinoInside.Revit.GH/Types/GraphicalElement.cs
@@ -96,6 +96,7 @@ public static bool IsValidElement(ARDB.Element element)
         case ARDB.SpatialElementTag _:      return true;
         case ARDB.IndependentTag _:         return true;
 
+        case ARDB.Structure.BoundaryConditions _: return true;
 #if REVIT_2023
         case ARDB.Structure.AnalyticalElement _: return true;
 #else