-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT][Docs] Revise run methods/deployment docs #945
base: main
Are you sure you want to change the base?
Conversation
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2025-01-15 14:55:40 UTC Link: vizro-core/examples/dev/ Link: vizro-core/examples/scratch_dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great refactoring 👍
I have a question: should the Gunicorn section go under deployment? It mentions deployment so naturally would fit better, right?
I agree that the "Gunicorn" section should go under the "Deployment". Great spot!
Also, and maybe related, I am concerned that we aren't that tight about language, or maybe it's my understanding. The file is called run.md and the ToC had the page listed as "Run methods" but we mostly talk about "launching" and then Gunicorn talks about deployment, then there's a section on deployment. Can I get clarity on the difference, or not, in what we mean by "run", "launch" and "deploy" and then I'll run through again and ensure everything is consistent.
I understand the confusion because these terms are quite intertwined here.
So, "run" and "launch" are the same terms that describe running/launching the app locally
(for the development purpose).
However, deployment means more like setting-up and running the production-ready app somewhere on the server
(not locally).
Also, I like the "Launch the dashboard" title, and also the suggestion to move "Gunicorn" under the "Deployment" section. I guess we should rename the file from run.md
-> launch_the_dashboard.md
, and align wordings across documents accordingly.
Thanks @petar-qb, that's really helpful feedback! |
Description
I've made a few changes in the
run.md
file to improve readability. This is on top of the change to come to add Dash Enterprise to this page (I have separated that change into a separate PR: #947).run.md
and the ToC had the page listed as "Run methods" but we mostly talk about "launching" and then Gunicorn talks about deployment, then there's a section on deployment.Can I get clarity on the difference, or not, in what we mean by "run", "launch" and "deploy" and then I'll run through again and ensure everything is consistent.
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":