[POC] Actions to class #911

antonymilne · 2024-12-02T09:48:40Z

Description

Screenshot

Notice

I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
- I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
- I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
- I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
- I have not referenced individuals, products or companies in any commits, directly or indirectly.
- I have not added data or restricted code in any commits, directly or indirectly.

…s-based

…om actions so they can take in parameters and filters too - doesn't work easily because need to mix and match positional and keyword args in captured callable

…for custom actions so they can take in parameters and filters too - doesn't work easily because need to mix and match positional and keyword args in captured callable" This reverts commit c946494.

…tion class like built-in ones or use shortcut @capture_new_action method. Current issues: * export_data and filter_interaction are public so still need to work using old method. This is why QA tests are failing. Need to make new_export_data that does it new way and keep old one for legacy? * have some good ideas for how to handle inputs of custom action but not sure how to handle outputs - ideas given in _action.py and app.py PR #911 was nearly there and first commits on this branch were tidying that, but then realised that pydantic model is probably better than CapturedCallable (see paper notes) so tried this new approach.

antonymilne added 10 commits November 20, 2024 15:37

Move filter_action to class - untested

0549fd4

Try different route - use OPL as function in filter also

9fc90f0

Use OPL in parameter too

5f327a8

Move export_data to class-based action

9a1f4ca

Remove outputs from _on_page_load and move filter_interaction to clas…

c55d6a8

…s-based

Move inputs and outputs to CapturedActionCallable

5d773eb

Idea to also use CapturedActionCallable in capture decorator for cust…

c946494

…om actions so they can take in parameters and filters too - doesn't work easily because need to mix and match positional and keyword args in captured callable

Revert "Idea to also use CapturedActionCallable in capture decorator …

f4746b6

…for custom actions so they can take in parameters and filters too - doesn't work easily because need to mix and match positional and keyword args in captured callable" This reverts commit c946494.

Add a few comments

ee67a74

Add notes

51de6ee

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[POC] Actions to class #911

[POC] Actions to class #911

antonymilne commented Dec 2, 2024 •

edited

Loading

[POC] Actions to class #911

Are you sure you want to change the base?

[POC] Actions to class #911

Conversation

antonymilne commented Dec 2, 2024 • edited Loading

Description

Screenshot

Notice

antonymilne commented Dec 2, 2024 •

edited

Loading