-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy] Replace dmc.Switch
with dbc.Switch
#907
Conversation
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2024-12-02 11:38:05 UTC Link: vizro-core/examples/dev/ Link: vizro-core/examples/scratch_dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! 👍
If you find it useful, extract the creation of the dbc.Switch
in a separate helper function (and reuse it in two places) in the dashboard.py
.
You can also change the variable names in the dashboard.js
(but also not necessary 😄).
Thanks for the quick review! 🙏 For now, I think it's easier to stick with the duplication. Normally, we only need to insert the theme-switch once for all dashboard pages, but the 404 page is an exception since it gets rendered separately and we want it to match. If we come across more cases like the 404 page, we can definitely reconsider. 👍 For now, I find the duplication clearer because having a helper function outside the Dashboard class would make it harder to overwrite, and it doesn't quite qualify as a separate method within the Dashboard class, as it's already part of the output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ 🌟 ⭐ 🌟 ⭐ 🌟 ⭐ So nice to see everything being consolidated into bootstrap here!
Now the only dmc component left is the date picker?
Yeees! |
Description
dmc.Switch
withdbc.Switch
dbc.Switch
-> https://github.com/McK-Private/vizro-bootstrap/pull/40dmc.Switch
with updatedvizro-bootstrap.min.css
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":