Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] VizroAI UI tests #882

Merged
merged 57 commits into from
Jan 27, 2025
Merged

[QA] VizroAI UI tests #882

merged 57 commits into from
Jan 27, 2025

Conversation

l0uden
Copy link
Contributor

@l0uden l0uden commented Nov 18, 2024

Description

Moved VizroAI UI tests from vizro-qa

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@github-actions github-actions bot added the Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package label Nov 18, 2024
@l0uden l0uden changed the base branch from main to qa/component_library_tests November 18, 2024 12:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2025-01-27 10:26:14 UTC
Commit: 45df962

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

@l0uden l0uden changed the base branch from qa/component_library_tests to main November 18, 2024 12:14
@l0uden l0uden changed the base branch from main to qa/component_library_tests November 18, 2024 12:20
Base automatically changed from qa/component_library_tests to main November 26, 2024 11:11
l0uden and others added 5 commits December 12, 2024 13:41
l0uden and others added 15 commits December 24, 2024 12:56
@l0uden
temp uv fix
01dcdc6
@l0uden
Merge branch 'qa/vizro_ai_ui_tests' of https://github.com/mckinsey/vizro
7c78959 
 into qa/vizro_ai_ui_tests

� Conflicts:
�	vizro-core/hatch.toml
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4f93588 
for more information, see https://pre-commit.ci
@l0uden
get conftest back to integration
986872b
@l0uden
Merge branch 'qa/vizro_ai_ui_tests' of https://github.com/mckinsey/vizro
725b7b2 
 into qa/vizro_ai_ui_tests
@antonymilne
Propose rename for future
c2f13f4
@l0uden
Merge branch 'main' of https://github.com/mckinsey/vizro into qa/vizr…
dde3430 
…o_ai_ui_tests
@l0uden
refactor tests structure and naming
91e88ab
@l0uden
changes wait port
30acedc
@l0uden
make dashboard_ui run with dash_duo
d6282c1
@l0uden
Merge branch 'main' of https://github.com/mckinsey/vizro into qa/vizr…
d313f0e 
…o_ai_ui_tests
@l0uden
move conftest with reset managers to vizro_ai_ui only
4e8d43e
@l0uden
fix test-vizro-ai-ui.yml
6bc8b30
@l0uden
linting
b28f5f9
@l0uden
webhook secret
56e6812
@l0uden l0uden requested a review from nadijagraca January 21, 2025 14:58
@l0uden
Copy link
Contributor Author

l0uden commented Jan 21, 2025

@nadijagraca , could you please take a look at the change for dashboard_ui dashboard?

@l0uden
Copy link
Contributor Author

l0uden commented Jan 21, 2025

@maxschulz-COL and @antonymilne , you take fresh look on the updated structure

maxschulz-COL
maxschulz-COL approved these changes Jan 22, 2025
View reviewed changes
vizro-ai/tests/conftest.py Outdated Show resolved Hide resolved
nadijagraca
nadijagraca approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great job Alexey. 🚀

antonymilne
antonymilne approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made lots of suggestions but I'm happy for you to merge it whenever you're ready. Some of them are bigger changes so no need to address all of them in this PR - I'm happy for you to do them another time.

.github/workflows/test-e2e-dashboard-score-vizro-ai.yml Outdated Show resolved Hide resolved
.github/workflows/test-vizro-ai-ui.yml Outdated Show resolved Hide resolved
vizro-ai/hatch.toml Outdated Show resolved Hide resolved
tools/tests/e2e_common_waiters.py Outdated Show resolved Hide resolved
vizro-ai/tests/vizro_ai_ui/test_vizro_ai_ui.py Outdated Show resolved Hide resolved
vizro-ai/tests/vizro_ai_ui/fake_data_generator.py Outdated Show resolved Hide resolved
tools/tests/e2e_common_waiters.py Outdated Show resolved Hide resolved
vizro-ai/tests/vizro_ai_ui/test_vizro_ai_ui.py Outdated Show resolved Hide resolved
vizro-ai/tests/vizro_ai_ui/test_vizro_ai_ui.py Outdated Show resolved Hide resolved
vizro-ai/tests/vizro_ai_ui/test_vizro_ai_ui.py Outdated Show resolved Hide resolved
@l0uden l0uden merged commit ccb65f3 into main Jan 27, 2025
44 checks passed
@l0uden l0uden deleted the qa/vizro_ai_ui_tests branch January 27, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxschulz-COL maxschulz-COL maxschulz-COL approved these changes

@nadijagraca nadijagraca nadijagraca approved these changes

@antonymilne antonymilne antonymilne approved these changes

@Joseph-Perkins Joseph-Perkins Awaiting requested review from Joseph-Perkins Joseph-Perkins is a code owner

@huong-li-nguyen huong-li-nguyen Awaiting requested review from huong-li-nguyen huong-li-nguyen is a code owner

@lingyielia lingyielia Awaiting requested review from lingyielia lingyielia is a code owner

Assignees
No one assigned
Labels
Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@l0uden @antonymilne @maxschulz-COL @nadijagraca