Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Enable dynamic filter #879

Merged
merged 77 commits into from
Dec 2, 2024
Merged
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
9449c73
Reduce to just one load function in filter.py
antonymilne Nov 4, 2024
b37f38f
Refactor set methods and add in __call__
antonymilne Nov 4, 2024
3d6f570
Fix tests
antonymilne Nov 4, 2024
68f6f61
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 4, 2024
9e6f62e
Add numpy lower bound
antonymilne Nov 4, 2024
574169b
Fix tests
antonymilne Nov 5, 2024
568dc58
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 5, 2024
b13e574
Fix tests
antonymilne Nov 5, 2024
01307bd
Add new tests and lint
antonymilne Nov 5, 2024
2ac895b
Final tidy
antonymilne Nov 5, 2024
2e4e0e2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 5, 2024
983940b
Fix min/max=0 bug
antonymilne Nov 6, 2024
13f022e
Move _get_targets_data_and_config into _get_modified_page_figures wit…
antonymilne Nov 6, 2024
a07fda4
Dynamic before filter tidy changes
petar-qb Nov 6, 2024
f2bd362
Turn _get_targets_data_and_config into _get_targets_data - tests pass
antonymilne Nov 6, 2024
1dbacb0
Turn _create_target_arg_mapping into _filter_dot_separated_string - t…
antonymilne Nov 6, 2024
f93d780
categorical selectors after the tidy/dynamic-filter
petar-qb Nov 6, 2024
4d0fb0e
Split up filtered and unfiltered data, create _multi_load, rework Fil…
antonymilne Nov 7, 2024
1a859ff
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 7, 2024
2b3b0ae
Support for Slider and RangeSlider to work as RadioItems
petar-qb Nov 7, 2024
30aa52a
Merge remote-tracking branch 'origin/main' into tidy/dynamic-filter-2
antonymilne Nov 7, 2024
d097733
Lint and small fixes
antonymilne Nov 7, 2024
0f5b096
pull changes from tidy/dynamic-filter-2
petar-qb Nov 8, 2024
d3c677e
dynamic filters implemented as on_page_load targets
petar-qb Nov 12, 2024
1d602ea
Propagating data_frame parameter values as load–kwargs from the model…
petar-qb Nov 13, 2024
2a94f6c
Merge main into the feature branch
petar-qb Nov 13, 2024
e066fdb
More improvements
petar-qb Nov 15, 2024
9e5a239
Reverting: Sending DFP values from the MM to Filter.pre_build DM._mul…
petar-qb Nov 15, 2024
5f161aa
Merge branch 'main' of https://github.com/mckinsey/vizro into feat/dy…
petar-qb Nov 15, 2024
cfdf4fc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 15, 2024
8ca5382
Minor code cleaning
petar-qb Nov 15, 2024
472f7a8
Solving conflicts
petar-qb Nov 15, 2024
1e3ba7f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 15, 2024
41adc9e
Minor refactoring
petar-qb Nov 15, 2024
b912bb0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 15, 2024
1d2a9c5
Minor refactoring
petar-qb Nov 15, 2024
d1bd246
Merge branch 'feat/dynamic-filter' of https://github.com/mckinsey/viz…
petar-qb Nov 15, 2024
a89b8bf
Minor comment change
petar-qb Nov 18, 2024
48e6716
More refactoring
petar-qb Nov 18, 2024
161a1e9
Remove fetching unfiltered data for filter.targets
petar-qb Nov 19, 2024
e1db7ec
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 19, 2024
f13d131
Merge main with the feature branch
petar-qb Nov 19, 2024
b450404
Addressing PR comments
petar-qb Nov 21, 2024
82838f1
Lint
petar-qb Nov 21, 2024
53d73e5
Merge main with the feature branch
petar-qb Nov 21, 2024
db017a2
Unit tests
petar-qb Nov 25, 2024
e6208fa
Lint
petar-qb Nov 25, 2024
cad4694
Merge branch 'main' of https://github.com/mckinsey/vizro into feat/dy…
petar-qb Nov 25, 2024
a03aa45
[Docs] Dynamic filters (#891)
antonymilne Nov 25, 2024
985ec4c
Add review comments and questions and small changes
antonymilne Nov 25, 2024
66da134
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 25, 2024
3c60502
Add review comments and questions and small changes
antonymilne Nov 25, 2024
ca6b4ad
Add todo for filter.build()
petar-qb Nov 26, 2024
9fd0f1d
First chunk of PR comments
petar-qb Nov 26, 2024
1433734
_get_min_max and _get_options improvements
petar-qb Nov 27, 2024
fa5f172
Simple Filter.__call__() tests
petar-qb Nov 28, 2024
d91a151
Removing FILTER_COLUMN from app.py
petar-qb Nov 28, 2024
0bf501c
Merge main with the feature branch
petar-qb Nov 28, 2024
097c02e
Removing TODO
petar-qb Nov 28, 2024
86171e0
Hide selector during the dynamic filter reloading process
petar-qb Nov 29, 2024
9732692
A few comments added
petar-qb Nov 29, 2024
4c0f8e8
Docs improvements
antonymilne Nov 29, 2024
ff6f89a
Update vizro-core/docs/pages/user-guides/data.md
antonymilne Nov 29, 2024
9da32a8
Update vizro-core/docs/pages/user-guides/data.md
antonymilne Nov 29, 2024
9fc39e8
Update vizro-core/docs/pages/user-guides/data.md
antonymilne Nov 29, 2024
c037740
Update vizro-core/docs/pages/user-guides/data.md
antonymilne Nov 29, 2024
7ed7385
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 29, 2024
befb14d
Update vizro-core/docs/pages/user-guides/data.md
antonymilne Nov 29, 2024
1d9f606
Update vizro-core/docs/pages/user-guides/filters.md
antonymilne Nov 29, 2024
97aa9d1
Update vizro-core/docs/pages/user-guides/filters.md
antonymilne Nov 29, 2024
28562c3
Update vizro-core/docs/pages/user-guides/data.md
antonymilne Nov 29, 2024
ecba967
Update vizro-core/docs/pages/user-guides/data.md
antonymilne Nov 29, 2024
aa38a40
Remove one comment
petar-qb Nov 29, 2024
8fde5d9
Merge branch 'main' of https://github.com/mckinsey/vizro into feat/dy…
petar-qb Nov 29, 2024
744931d
TestFilterCall refactoring
petar-qb Nov 29, 2024
ca07e82
Merge branch 'main' of https://github.com/mckinsey/vizro into feat/dy…
petar-qb Nov 30, 2024
81a9bdb
PR comment referenced in the _actions_utils
petar-qb Dec 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update vizro-core/docs/pages/user-guides/data.md
antonymilne authored Nov 29, 2024
commit befb14d989bbd33c2fbe468d24db7ca591b9da3a
2 changes: 1 addition & 1 deletion vizro-core/docs/pages/user-guides/data.md
Original file line number Diff line number Diff line change
@@ -415,4 +415,4 @@ When Vizro initially builds a filter that depends on parametrized dynamic data l

!!! note

When a dynamic data parameter is changed on screen, the data underlying a dynamic filter can change. Currently this change affects page components such as `vm.Graph` but does not affect the available values shown in a dynamic filter, which only update on page refresh. This functionality will be coming soon!
When the value of a dynamic data parameter is changed by a dashboard user, the data underlying a dynamic filter can change. Currently this change affects page components such as `vm.Graph` but does not affect the available values shown in a dynamic filter, which only update on page refresh. This functionality will be coming soon!