[QA] Component library tests

[l0uden]

Description

Moved component library tests from vizro-qa

Notice

• I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
  • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
  • I have not referenced individuals, products or companies in any commits, directly or indirectly.
  • I have not added data or restricted code in any commits, directly or indirectly.

[github-actions]

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2024-11-25 15:29:21 UTC
Commit: 335fd21

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

[antonymilne]

Generally looks good 👍 I have lots of questions and comments just to make sure we get the initial structure and naming right. I'm not so familiar with testing images either so except lots of questions!

In general, as we move code into our main repo I'm going to apply a slightly higher standard of review compared to the vizro-qa repo so there might be a lot of comments! Very happy to discuss anything that's not clear though 🙂

[l0uden]

@antonymilne , thanks for the very useful review comments!
I've fixed them all without comments under your reviews, but left answers were it was most important.

[antonymilne]

This looks really great, thank you!

I've added a few more minor suggestions. Most important thing is I don't think assert_image_equal quite makes sense yet and we should probably break it into two functions. See what you think.

Once you've made any changes based on this round of review let's get @maxschulz-COL to have a final look through and then it's good to merge 💯

[l0uden]

@antonymilne , finished with your latest suggestions

[antonymilne]

Looks good, just made a small suggestion but otherwise @maxschulz-COL please could you do a quick check through and then feel free to merge!

[maxschulz-COL]

Looks good to me, thanks also for A to make such a thorough review before. I didn't write down any comment, but I think the e2e_asserts.py would benefit from a few inline code comments about what you are doing. Since not everyone will be super familiar with cv2 etc, it is sometime hard to guess what even the overall strategy is. Maybe a few comments guide a reader on what the code is doing might be helpful?

[l0uden]

Looks good to me, thanks also for A to make such a thorough review before. I didn't write down any comment, but I think the e2e_asserts.py would benefit from a few inline code comments about what you are doing. Since not everyone will be super familiar with cv2 etc, it is sometime hard to guess what even the overall strategy is. Maybe a few comments guide a reader on what the code is doing might be helpful?

Left comments about cv2 logic

All your comment are now addressed, thanks!