Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo] Fix diverging stacked bar in ViViVo #864

Merged
merged 12 commits into from
Nov 14, 2024
Merged

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Nov 12, 2024

Description

  • Fix order of traces to be consistent with legend order
  • A couple of open questions / thoughts I would like to discuss later @antonymilne

Screenshot

Before:

I would recommend this pastry to my friends

After:

386191622-8bbb1ce8-4ec5-4244-a940-b19cadc9942c

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

Copy link
Contributor

github-actions bot commented Nov 12, 2024

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2024-11-14 08:53:10 UTC
Commit: 11cd731

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

@huong-li-nguyen huong-li-nguyen self-assigned this Nov 12, 2024
@huong-li-nguyen huong-li-nguyen changed the title [Demo] Fix diverging stacked bar [Demo] Fix diverging stacked bar in ViViVo Nov 14, 2024
Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these two bugfixes!! The chart is much more readable now 🎨
May you update the PR description with the latest version of this chart?

image

@huong-li-nguyen huong-li-nguyen merged commit 36699ee into main Nov 14, 2024
36 checks passed
@huong-li-nguyen huong-li-nguyen deleted the demo/fix-visual-vocab branch November 14, 2024 13:48
nadijagraca pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants