Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NavBar as selector for Navigation #70

Merged
merged 117 commits into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from 84 commits
Commits
Show all changes
117 commits
Select commit Hold shift + click to select a range
ff92666
initial changes to add NavBar and Icon model, make Accordion model pu…
nadijagraca Sep 13, 2023
010b051
enabling single icon in the nav bar
nadijagraca Sep 22, 2023
c15e4d5
adding styling to nav bar
nadijagraca Sep 22, 2023
a7a1d87
initial changes to allow multiple icons
nadijagraca Sep 26, 2023
8d6d9cf
erge main
nadijagraca Sep 26, 2023
7206b62
initial code refactoring
nadijagraca Sep 26, 2023
8acb6c0
fixing accordion highlight issue
nadijagraca Sep 26, 2023
26637f2
Merge branch 'main' into vizro-core/models-navigation-navbar
nadijagraca Sep 26, 2023
3033abd
fixing accordion item highlight bug
nadijagraca Sep 27, 2023
b4cbf9f
removing background color highlight from selected accordion, aligning…
nadijagraca Sep 28, 2023
f630b50
added changelog
nadijagraca Sep 28, 2023
d843b1d
minor linting fixes'
nadijagraca Sep 28, 2023
417ca3c
fixed tests
nadijagraca Sep 28, 2023
19983a8
Merge branch 'main' into vizro/bug/highlight_active_accordion_item
huong-li-nguyen Oct 2, 2023
e6307aa
Lint
huong-li-nguyen Oct 2, 2023
9fecf3c
Replace active class with active param
huong-li-nguyen Oct 2, 2023
8cd1bfc
Merge branch 'main' into vizro/bug/highlight_active_accordion_item
huong-li-nguyen Oct 2, 2023
5768665
Merge branch 'main' into vizro/bug/highlight_active_accordion_item
huong-li-nguyen Oct 3, 2023
901c7f2
Merge branch 'main' into vizro/bug/highlight_active_accordion_item
huong-li-nguyen Oct 3, 2023
4bdca79
Refactor code
huong-li-nguyen Oct 3, 2023
e320bb8
Fix tests
huong-li-nguyen Oct 3, 2023
ca5e675
Lint
huong-li-nguyen Oct 3, 2023
56ebe70
Merge branch 'main' into vizro/bug/highlight_active_accordion_item
huong-li-nguyen Oct 3, 2023
5081c89
Move page registering to Dashboard.pre_build
huong-li-nguyen Oct 3, 2023
6401a26
Update changelog
huong-li-nguyen Oct 3, 2023
a9dc868
Remove Accordion.build from page.build
huong-li-nguyen Oct 3, 2023
e3851c3
Remove navigation.pre_build from page and fix tests
huong-li-nguyen Oct 3, 2023
fef2951
Merge branch 'main' into vizro-core/models-navigation-navbar
huong-li-nguyen Oct 4, 2023
ecd2f04
Resolve merge conlicts
huong-li-nguyen Oct 4, 2023
1ce251e
Merge branch 'vizro/bug/highlight_active_accordion_item' into vizro-c…
huong-li-nguyen Oct 4, 2023
40ec167
Update utils
huong-li-nguyen Oct 4, 2023
ea53162
Fix merge differences
huong-li-nguyen Oct 4, 2023
4dee420
Remove unused css classes
huong-li-nguyen Oct 4, 2023
203975f
Update changelog
huong-li-nguyen Oct 4, 2023
2fa3429
PR comments
huong-li-nguyen Oct 4, 2023
947cdaf
Merge branch 'main' into vizro/bug/highlight_active_accordion_item
huong-li-nguyen Oct 4, 2023
a316e42
Fix access to dash.page_registry
huong-li-nguyen Oct 4, 2023
81f570f
Merge branch 'vizro/bug/highlight_active_accordion_item' into vizro-c…
huong-li-nguyen Oct 4, 2023
c0d7a06
Merge branch 'main' into vizro-core/models-navigation-navbar
huong-li-nguyen Oct 4, 2023
316cd23
Fix import as Annotated not available in python38
huong-li-nguyen Oct 5, 2023
04109b4
renaming navigation containers in page modes
nadijagraca Sep 27, 2023
5ce18b0
adding initial validation for navbar items
nadijagraca Sep 29, 2023
c175d11
adding toopltio functionality
nadijagraca Oct 9, 2023
3866c35
minor fixes due to linting
nadijagraca Oct 10, 2023
3971a98
adding css drawn placeholder image if icon src not provided
nadijagraca Oct 11, 2023
4ce6251
enabling pages - non refactored/initial implementation
nadijagraca Oct 13, 2023
dae1824
merge main
nadijagraca Oct 19, 2023
f3e0aae
minor changes to nav bar and navitem models
nadijagraca Oct 19, 2023
d670b9b
minor refactoring
nadijagraca Oct 19, 2023
4229f62
minor changes to navitem model
nadijagraca Oct 19, 2023
720e52d
addressing pr comments part 1
nadijagraca Oct 24, 2023
a9a24e2
fixing navigation selector validation
nadijagraca Oct 24, 2023
1673646
addressing pr comments part 2
nadijagraca Oct 25, 2023
f3721ef
minor fixes due to linting
nadijagraca Oct 25, 2023
a73578e
merge main
nadijagraca Oct 25, 2023
b44922f
minor change to types
nadijagraca Oct 25, 2023
8c7989a
Merge branch 'main' into vizro-core/models-navigation-navbar
huong-li-nguyen Oct 26, 2023
cbc943b
small changes due to pr comment
nadijagraca Oct 26, 2023
3ced66f
Enable reading icons from google
huong-li-nguyen Oct 26, 2023
d6eae78
removing nav_controls_panel if only one page in the accordion
nadijagraca Oct 26, 2023
388a93b
addressing pr comments part 3
nadijagraca Oct 27, 2023
656491a
fixing different configuration option for navigation
nadijagraca Oct 27, 2023
222b583
Implement root_validator for text and tooltip
huong-li-nguyen Oct 30, 2023
b9c9776
Change order of validators
huong-li-nguyen Oct 30, 2023
4b09dfa
Merge branch 'main' into vizro-core/models-navigation-navbar
huong-li-nguyen Oct 30, 2023
7233c24
Update 0.1.6.dev0.json
huong-li-nguyen Oct 30, 2023
38ad9ed
adding padding to NavItem text
nadijagraca Oct 30, 2023
af21ff0
fixing navigation and accordion tests
nadijagraca Oct 30, 2023
df750a7
merge main
nadijagraca Oct 30, 2023
63391a2
linting
nadijagraca Oct 30, 2023
14ae166
Move test for default navigation
huong-li-nguyen Oct 30, 2023
d5f0502
Revert changes in previous schema
huong-li-nguyen Oct 30, 2023
2d8fb28
addressing pr comments part 4
nadijagraca Oct 31, 2023
1563c51
allowing users to build navigation without providing all registered p…
nadijagraca Nov 1, 2023
cebb376
merge main
nadijagraca Nov 1, 2023
ac6fe82
fixing lint issue
nadijagraca Nov 1, 2023
e5f7730
first draft docs
nadijagraca Nov 2, 2023
b72e35e
merge main
nadijagraca Nov 2, 2023
960203c
adding tests for NavBar model
nadijagraca Nov 3, 2023
821a2fa
adding tests for navbar
nadijagraca Nov 6, 2023
df06b4b
addding tests
nadijagraca Nov 6, 2023
4ff1100
adding unit tests for navitem
nadijagraca Nov 7, 2023
d962e1f
Merge branch 'main' into vizro-core/models-navigation-navbar
nadijagraca Nov 8, 2023
351637c
further formating of navigation docs
nadijagraca Nov 10, 2023
a890841
further adjustments to navigation docs
nadijagraca Nov 10, 2023
6343e02
Move Google icon to external stylesheets
antonymilne Nov 14, 2023
d6dae13
Add notes to self
antonymilne Nov 14, 2023
19112cd
Tidy filter validator
antonymilne Nov 14, 2023
702687f
Tidy default values
antonymilne Nov 14, 2023
54bdd47
Refactor navigation bits
antonymilne Nov 14, 2023
c9a7d4a
Fix bugs
antonymilne Nov 15, 2023
26c88f5
Tidy comments and make sure nav_control_panel hidden when not wanted
antonymilne Nov 15, 2023
99acc01
Remove Optional in favour of proper default values
antonymilne Nov 15, 2023
f6a4b30
Fix bug I stupidly introduced
antonymilne Nov 16, 2023
4c92bac
Merge remote-tracking branch 'origin/main' into vizro-core/models-nav…
antonymilne Nov 16, 2023
5232eb0
Big test update
antonymilne Nov 16, 2023
0ab4dfc
Big rename
antonymilne Nov 17, 2023
9eb03ee
Lint
antonymilne Nov 17, 2023
aa20379
Lint
antonymilne Nov 17, 2023
8ad2b06
Lint
antonymilne Nov 17, 2023
e69f008
Fix stupid bug
antonymilne Nov 21, 2023
dee6612
Add integration tests
antonymilne Nov 22, 2023
c44234c
Add type hints
antonymilne Nov 23, 2023
4de4131
Add custom assert for tests
antonymilne Nov 23, 2023
452657e
Add custom assert for tests
antonymilne Nov 23, 2023
941eb8a
Fix imports in test_types
antonymilne Nov 23, 2023
c7e8b49
Use assert_components_equal in other navigation tests
antonymilne Nov 23, 2023
7fa028e
Rename assert_component_equal
antonymilne Nov 24, 2023
4711fee
Update docs
antonymilne Nov 28, 2023
6efabd2
Update docs
antonymilne Nov 28, 2023
5f5ceba
Rearrange test fixtures
antonymilne Nov 28, 2023
8d9988a
Write docstrings
antonymilne Nov 28, 2023
6e2f3de
FIx test and generate schema
antonymilne Nov 28, 2023
4e10206
Add changelog
antonymilne Nov 28, 2023
4de4de0
Revert changes to dashboard
antonymilne Nov 28, 2023
271105d
Update vizro-core/src/vizro/models/__init__.py
antonymilne Nov 29, 2023
1e10932
Merge branch 'main' into vizro-core/models-navigation-navbar
antonymilne Nov 29, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<!--
A new scriv changelog fragment.

Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Removed

- A bullet item for the Removed category.

-->

### Added

- Enable `NavBar` as a selector for `Navigation` to create icon and text navigation bars ([#70](https://github.com/mckinsey/vizro/pull/70))

<!--
### Changed

- A bullet item for the Changed category.

-->
<!--
### Deprecated

- A bullet item for the Deprecated category.

-->
<!--
### Fixed

- A bullet item for the Fixed category.

-->
<!--
### Security

- A bullet item for the Security category.

-->
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading