[Bot] pre-commit autoupdate #674
Conversation
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.6 → v0.6.3](astral-sh/ruff-pre-commit@v0.5.6...v0.6.3) - [github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.11.2](pre-commit/mirrors-mypy@v1.10.1...v1.11.2) - [github.com/errata-ai/vale: v3.7.0 → v3.7.1](errata-ai/vale@v3.7.0...v3.7.1)
pre-commit-ci
bot
requested review from
Joseph-Perkins,
antonymilne,
huong-li-nguyen and
maxschulz-COL
as code owners
for more information, see https://pre-commit.ci
pre-commit-ci
bot
requested review from
Anna-Xiong and
lingyielia
as code owners
There was a problem hiding this comment.
@maxschulz-COL @lingyielia - could you finish this PR off?
I've reverted the mypy version, because we cannot update as long as we don't use Pydantic V2. With the latest version of ruff, lots of linting errors are raised from the notebooks inside vizro-ai.
I think some of them you can probably safely ignore (prints), others might be worth implementing (docstrings / line length). So either push a change to ignore certain rules or fix the linting errors :)
huong-li-nguyen
changed the title
There was a problem hiding this comment.
@lingyielia - I am sure it's possible, but could you check if one can ignore certain rules in ruff per files?
Because, essentially you don't want to add an ignore in each line, but rather ignore that rule for all notebooks inside vizro-ai. For example the print rule. If not easy to implement, then happy to merge as is 👍
updates: