-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Enable dashboard code generation #641
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, just a few rough bits of implementation that could be improved 👍 So it's an approval because I know you don't want to wait too long on this.
Out of my suggestion I would maybe try to improve _process_to_set
now and then leave create
for another time, but up to you! Some of it is maybe not worth dedicating time to improve if it becomes redundant soon with the plot refactoring, so the comments are more just meant as useful feedback rather than changes that should necessarily be made.
Description
Current version of output:
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":