-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA] Add unit tests for vizro-ai dashboard #614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks for already putting together so many tests. My comments are mainly on additional tests we could create. Let me know if any one of them is not clear.
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/conftest.py
Outdated
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_components.py
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_controls.py
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_controls.py
Outdated
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_controls.py
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_df_info.py
Outdated
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_layout.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, didn't get all that far, but tried to make some useful comments! THanks a lot already, this is really important!
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_components.py
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I wizzed through, trying to spot any major things. I think we can merge soon - let me know if any of the comments are unclear.
Thanks for tackling this very daunting task - it really is not easy 💪 !
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_components.py
Outdated
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_controls.py
Outdated
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_controls.py
Outdated
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_controls.py
Outdated
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_controls.py
Outdated
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_layout.py
Outdated
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_layout.py
Outdated
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_dashboard.py
Outdated
Show resolved
Hide resolved
vizro-ai/tests/unit/vizro-ai/dashboard/_response_models/test_page.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work on building up all these tests for dashboard! Happy to merge this version as it's in a very good shape now.
Description
components.py
ComponentPlan
ComponentPlan
controls.py
_create_filter_proxy
_create_filter
ControlPlan
dashboard.py
DashboardPlanner
df_info.py
_get_df_info
_create_df_info_content
layout.py
_convert_to_grid
LayoutPlan
page.py
PagePlanner
Page Planner validation functions
_get_layout
,_build_layout
,_controllable_components
,create
,_get_controls
To-do list:
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":