Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Add unit tests for vizro-ai dashboard #614

Merged
merged 24 commits into from
Aug 20, 2024

Conversation

nadijagraca
Copy link
Contributor

@nadijagraca nadijagraca commented Aug 2, 2024

Description

  • components.py

testing unit comment status
ComponentPlan for majority real model is required to test.
ComponentPlan On to-do list components plan instantiation
  • controls.py

testing unit comment status
_create_filter_proxy tested all but validation for datepicker - datepicker on to-do list
_create_filter tested
ControlPlan tested validation for ControlPlan
  • dashboard.py

testing unit comment status
DashboardPlanner tested DashboardPlanner instantiation
  • df_info.py

testing unit comment status
_get_df_info tested if it produces correct df_schema and df sample
_create_df_info_content On to-do list - the string it produces is quite large
  • layout.py

testing unit comment status
_convert_to_grid tested valid and invalid option
LayoutPlan tested
  • page.py

testing unit comment status
PagePlanner PagePlanner instantiation
Page Planner validation functions tested
_get_layout, _build_layout, _controllable_components, create, _get_controls not tested as these require actual model

To-do list:

  • components plan instantiation
  • _create_df_info_content
  • validation for controls datepicker

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@nadijagraca nadijagraca added Docs 🗒️ Issue for markdown and API documentation Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package labels Aug 2, 2024
@nadijagraca nadijagraca self-assigned this Aug 2, 2024
Copy link
Contributor

@lingyielia lingyielia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for already putting together so many tests. My comments are mainly on additional tests we could create. Let me know if any one of them is not clear.

@nadijagraca nadijagraca requested a review from lingyielia August 5, 2024 15:45
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, didn't get all that far, but tried to make some useful comments! THanks a lot already, this is really important!

@nadijagraca nadijagraca removed the Docs 🗒️ Issue for markdown and API documentation label Aug 8, 2024
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I wizzed through, trying to spot any major things. I think we can merge soon - let me know if any of the comments are unclear.

Thanks for tackling this very daunting task - it really is not easy 💪 !

Copy link
Contributor

@lingyielia lingyielia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work on building up all these tests for dashboard! Happy to merge this version as it's in a very good shape now.

@nadijagraca nadijagraca merged commit a1b34c2 into main Aug 20, 2024
39 checks passed
@nadijagraca nadijagraca deleted the qa/vizroai/dashboard/add_unit_tests branch August 20, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants