-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy] Use BaseChatModel for type hint #550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 04:37 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
circleci_secrets
June 27, 2024 04:37 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 04:37 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 04:37 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 04:37 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 04:37 — with
GitHub Actions
Inactive
lingyielia
changed the title
Use BaseChatModel for type hint
[Tidy] Use BaseChatModel for type hint
Jun 27, 2024
lingyielia
temporarily deployed
to
circleci_secrets
June 27, 2024 04:40 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 04:40 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 04:40 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 04:40 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 04:40 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 04:40 — with
GitHub Actions
Inactive
lingyielia
requested review from
Joseph-Perkins,
Anna-Xiong and
maxschulz-COL
as code owners
June 27, 2024 04:43
1 task
lingyielia
temporarily deployed
to
circleci_secrets
June 27, 2024 04:56 — with
GitHub Actions
Inactive
maxschulz-COL
approved these changes
Jun 27, 2024
lingyielia
force-pushed
the
tidy/use_basechatmodel
branch
from
June 27, 2024 11:29
db40c94
to
d2887fc
Compare
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 11:29 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 11:29 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 11:29 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
circleci_secrets
June 27, 2024 11:29 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 11:29 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 11:29 — with
GitHub Actions
Inactive
lingyielia
force-pushed
the
tidy/use_basechatmodel
branch
from
June 27, 2024 13:12
d2887fc
to
49ea238
Compare
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 13:12 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
circleci_secrets
June 27, 2024 13:12 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 13:12 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 13:12 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 13:12 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 13:12 — with
GitHub Actions
Inactive
lingyielia
force-pushed
the
tidy/use_basechatmodel
branch
from
June 27, 2024 13:51
49ea238
to
c285589
Compare
lingyielia
temporarily deployed
to
circleci_secrets
June 27, 2024 13:51 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 13:51 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 13:51 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 13:51 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 13:51 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 13:51 — with
GitHub Actions
Inactive
antonymilne
approved these changes
Jun 27, 2024
lingyielia
force-pushed
the
tidy/use_basechatmodel
branch
from
June 27, 2024 16:48
c285589
to
fd2e16d
Compare
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 16:48 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
circleci_secrets
June 27, 2024 16:48 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 16:48 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 16:48 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 16:48 — with
GitHub Actions
Inactive
lingyielia
temporarily deployed
to
vizro_ai_secrets
June 27, 2024 16:48 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation:
when adding optional model families, in current setting, LLM_MODELS value varies based on import result
Use the parent class of all langchain supported chat models
Then we don't need this lines of code:
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":