Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Update tenacity dependency to fix failing unit tests #530

Closed
wants to merge 6 commits into from

Conversation

Anna-Xiong
Copy link
Contributor

@Anna-Xiong Anna-Xiong commented Jun 17, 2024

Description

Fix failing vizro ai unit tests:
Set tenacity upper bound to avoid issue described in langchain-ai/langchain#22972.

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@Anna-Xiong Anna-Xiong temporarily deployed to circleci_secrets June 17, 2024 16:41 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 16:41 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 16:41 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 16:41 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 16:41 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 16:41 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to circleci_secrets June 17, 2024 16:43 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 16:43 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 16:43 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 16:43 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 16:43 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 16:43 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong marked this pull request as ready for review June 17, 2024 16:46
@Anna-Xiong Anna-Xiong self-assigned this Jun 17, 2024
@Anna-Xiong Anna-Xiong added Status: Ready for Review ☑️ Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package labels Jun 17, 2024
@Anna-Xiong Anna-Xiong mentioned this pull request Jun 17, 2024
1 task
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@antonymilne
Copy link
Contributor

What is the version that actually causes a problem here? If it's 8.4.0 then a much better version specifier would be !=8.4.0, so that when a fixed version, say 8.4.1, comes out then you don't need to change the requirement again.

@Anna-Xiong
Copy link
Contributor Author

Anna-Xiong commented Jun 17, 2024

What is the version that actually causes a problem here? If it's 8.4.0 then a much better version specifier would be !=8.4.0, so that when a fixed version, say 8.4.1, comes out then you don't need to change the requirement again.

It is the newly released version 8.4.0( only released a few hours ago), they now have even newer version 8.4.1, i can try to see if 8.4.1 resolves the issue, otherwise probably let's pin under 8.4.0?

@Anna-Xiong Anna-Xiong temporarily deployed to circleci_secrets June 17, 2024 17:02 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 17:02 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 17:02 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 17:02 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 17:02 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 17, 2024 17:02 — with GitHub Actions Inactive
@huong-li-nguyen huong-li-nguyen changed the title Dev/update vizro ai dependency [QA] Update tenacity dependency to fix failing unit tests Jun 18, 2024
vizro-ai/snyk/requirements.txt Outdated Show resolved Hide resolved
vizro-ai/pyproject.toml Outdated Show resolved Hide resolved
@Anna-Xiong Anna-Xiong temporarily deployed to circleci_secrets June 18, 2024 08:09 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 18, 2024 08:09 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 18, 2024 08:09 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 18, 2024 08:09 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 18, 2024 08:09 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 18, 2024 08:09 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to circleci_secrets June 18, 2024 08:10 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 18, 2024 08:10 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 18, 2024 08:10 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 18, 2024 08:10 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 18, 2024 08:10 — with GitHub Actions Inactive
@Anna-Xiong Anna-Xiong temporarily deployed to vizro_ai_secrets June 18, 2024 08:10 — with GitHub Actions Inactive
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tenacity 8.4.1 has been released and fixes the problem then there should be no need for any changes at all here and we shouldn't add a transitive dependency to our requirements. Anyone doing pip install vizro-ai will get the latest version of tenacity unless there's some weird conflict that we know of that forces them into the problematic 8.4.0. So best to just not do anything here I think and close the PR.

@huong-li-nguyen
Copy link
Contributor

If the tenacity 8.4.1 has been released and fixes the problem then there should be no need for any changes at all here and we shouldn't add a transitive dependency to our requirements. Anyone doing pip install vizro-ai will get the latest version of tenacity unless there's some weird conflict that we know of that forces them into the problematic 8.4.0. So best to just not do anything here I think and close the PR.

Ah yes, main seems to be fixed now as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants