-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA] Update tenacity
dependency to fix failing unit tests
#530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What is the version that actually causes a problem here? If it's 8.4.0 then a much better version specifier would be |
It is the newly released version 8.4.0( only released a few hours ago), they now have even newer version |
tenacity
dependency to fix failing unit tests
Co-authored-by: Li Nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the tenacity 8.4.1 has been released and fixes the problem then there should be no need for any changes at all here and we shouldn't add a transitive dependency to our requirements. Anyone doing pip install vizro-ai
will get the latest version of tenacity unless there's some weird conflict that we know of that forces them into the problematic 8.4.0. So best to just not do anything here I think and close the PR.
Ah yes, main seems to be fixed now as well! |
Description
Fix failing vizro ai unit tests:
Set tenacity upper bound to avoid issue described in langchain-ai/langchain#22972.
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":