-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Update vizro ai integration test for dataclass output #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 6, 2024 19:52 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 6, 2024 19:52 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 6, 2024 19:52 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 6, 2024 19:52 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
circleci_secrets
June 6, 2024 19:52 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 6, 2024 19:52 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
circleci_secrets
June 6, 2024 21:49 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 6, 2024 21:49 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 6, 2024 21:49 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 6, 2024 21:49 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 6, 2024 21:49 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 6, 2024 21:49 — with
GitHub Actions
Inactive
Anna-Xiong
requested review from
Joseph-Perkins,
lingyielia and
maxschulz-COL
as code owners
June 6, 2024 21:52
l0uden
approved these changes
Jun 7, 2024
maxschulz-COL
changed the title
[Test] Update vizro ai integration test for datalcass output
[Test] Update vizro ai integration test for dataclass output
Jun 7, 2024
maxschulz-COL
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Does @l0uden need to change something for tests that are in the QA repo?
vizro-ai/changelog.d/20240606_155107_anna_xiong_update_vizro_ai_integration_test.md
Show resolved
Hide resolved
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 17, 2024 16:59 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
circleci_secrets
June 17, 2024 16:59 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 17, 2024 16:59 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 17, 2024 16:59 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 17, 2024 16:59 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 17, 2024 16:59 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
circleci_secrets
June 17, 2024 16:59 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 17, 2024 16:59 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 17, 2024 16:59 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 17, 2024 16:59 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 17, 2024 16:59 — with
GitHub Actions
Inactive
Anna-Xiong
temporarily deployed
to
vizro_ai_secrets
June 17, 2024 16:59 — with
GitHub Actions
Inactive
nadijagraca
pushed a commit
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
vizro-ai
integration test to use customized outputPlotOutputs
dataclass._return_all_text
private attributes is no longer needed and the output dictionary will be replaced by dataclassfor more details about the new feature please see [Feat] get vizro ai customized text output #488
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":