-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning to docs #416
Closed
Closed
Add warning to docs #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
# Conflicts: # vizro-core/docs/pages/user-guides/data.md
for more information, see https://pre-commit.ci
Co-authored-by: Li Nguyen <[email protected]> Signed-off-by: Antony Milne <[email protected]>
Co-authored-by: Li Nguyen <[email protected]> Signed-off-by: Antony Milne <[email protected]>
Co-authored-by: Maximilian Schulz <[email protected]> Signed-off-by: Antony Milne <[email protected]>
Co-authored-by: Petar Pejovic <[email protected]> Signed-off-by: Antony Milne <[email protected]>
Signed-off-by: Antony Milne <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Petar Pejovic <[email protected]> Signed-off-by: Antony Milne <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Jo Stichbury <[email protected]> Signed-off-by: Antony Milne <[email protected]>
for more information, see https://pre-commit.ci
antonymilne
requested review from
stichbury,
Joseph-Perkins,
huong-li-nguyen,
maxschulz-COL and
Anna-Xiong
as code owners
April 11, 2024 21:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#398 was merged when it was failing Snyk licence and security checks. I discussed this with @Joseph-Perkins and agreed we should ignore all the warnings but also add a note to our docs - done here.
I've thoroughly read up on the security issue and am not concerned as things stand. So long as dashboard developers use trusted data then all is well. If we ever allow untrusted users to upload data (e.g. through the dashboard) then we'd have to be much more careful though, since potentially that could be a big security risk that allows arbitrary code execution.
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":