-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy] Replace RadioItems
and Checklist
#414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…sey/vizro into tidy/replace_css_bootstrap
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
huong-li-nguyen
commented
Apr 17, 2024
huong-li-nguyen
requested review from
Joseph-Perkins,
antonymilne,
maxschulz-COL and
Anna-Xiong
as code owners
April 17, 2024 12:14
huong-li-nguyen
requested review from
pruthvip15,
petar-qb,
nadijagraca and
l0uden
April 17, 2024 14:43
nadijagraca
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.I like the use of html.Fieldset. 🚀
maxschulz-COL
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ LGTM!
vizro-core/changelog.d/20240410_192546_huong_li_nguyen_replace_radio_item.md
Outdated
Show resolved
Hide resolved
pruthvip15
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RadioItems
andChecklist
addedRadioItems
andChecklist
to use semantically correctFieldset
andLegend
, for context see: https://accessibility.blog.gov.uk/2016/07/22/using-the-fieldset-and-legend-elements/input-container
class from selectors to consolidate gapsTO DO
Screenshot
Run features demo dashboard:
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":