-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add favicon and changelogs #323
Conversation
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
vizro-ai/changelog.d/20240220_142800_jo_stichbury_add_favicon.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Jo Stichbury <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are the official images for vizro from branding: https://mckinsey.atlassian.net/wiki/spaces/VIZX/pages/577798204/Branding
I would use this one for the favicon - Vizro_IconOnly_TransparentBG.svg: https://mckinsey.box.com/s/tvb8dt9l4cblqs2sd19bu3vfb9uv5j6m
It's also the favicon we use for the hosted app :)
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
favicon looks great to me 👍 And agree that we should leave the logo alone for now and in the future make our docs more vizro-themed (vizriffic?) and figure out the right colour for it then.
FYI our setup for generating changelogs is basically optimised for people who only edit one package (vizro-ai
or vizro-core
) at a time, which is the case in 95% of PRs. If you end up editing both of them simultaneously a lot then you might like to make some alias for a command that does it for you:
cd vizro-core; hatch run changelog:add; cd ../vizro-ai; hatch run changelog:add; cd ..
So far we haven't been putting docs changes in our changelog at all (which I think is correct, but happy to discuss if you feel otherwise), so chances are high that you'll just need to leave this file empty every time.
Merging this and I've found and commented on a ticket for future Design work on the docs. |
Description
Added vizro favicon per #314
Yay, it's working: https://vizro-ai--323.org.readthedocs.build/en/323/ as an example
WDYT @Joseph-Perkins ?
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":