Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add max debug retry parameter #261

Merged
merged 11 commits into from
Jan 11, 2024
Merged

Feat/add max debug retry parameter #261

merged 11 commits into from
Jan 11, 2024

Conversation

Anna-Xiong
Copy link
Contributor

@Anna-Xiong Anna-Xiong commented Jan 10, 2024 •
edited
Loading

Description

  • add maximum debug retry in plot call
  • add docs for maximum debug retry

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@Anna-Xiong Anna-Xiong marked this pull request as ready for review January 10, 2024 16:11
@Anna-Xiong Anna-Xiong self-assigned this Jan 10, 2024
@Anna-Xiong Anna-Xiong added Status: Ready for Review ☑️ Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package labels Jan 10, 2024
maxschulz-COL
maxschulz-COL requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this. Have a few suggestions for the docs.

vizro-ai/docs/pages/user_guides/run_vizro_ai.md Outdated Show resolved Hide resolved
vizro-ai/docs/pages/user_guides/run_vizro_ai.md Outdated Show resolved Hide resolved
vizro-ai/docs/pages/user_guides/run_vizro_ai.md Outdated Show resolved Hide resolved
vizro-ai/docs/pages/user_guides/run_vizro_ai.md Outdated Show resolved Hide resolved
vizro-ai/docs/pages/user_guides/run_vizro_ai.md Outdated Show resolved Hide resolved
vizro-ai/docs/pages/user_guides/run_vizro_ai.md Outdated Show resolved Hide resolved
vizro-ai/src/vizro_ai/_vizro_ai.py Outdated Show resolved Hide resolved
vizro-ai/changelog.d/20240110_093842_anna_xiong_add_max_retry_parameter.md Outdated Show resolved Hide resolved
@Anna-Xiong
Copy link
Contributor Author

Hi @maxschulz-COL we changed the whole section shorter, and with layout easy to move in api reference in new PR

maxschulz-COL
maxschulz-COL reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton. Had another look and I think it's much snappier now. Made a suggestions for typos/text flow. Let me know what you think.

vizro-ai/changelog.d/20240110_093842_anna_xiong_add_max_retry_parameter.md Outdated Show resolved Hide resolved
vizro-ai/docs/pages/user_guides/run_vizro_ai.md Outdated Show resolved Hide resolved
vizro-ai/docs/pages/user_guides/run_vizro_ai.md Outdated Show resolved Hide resolved
vizro-ai/docs/pages/user_guides/run_vizro_ai.md Outdated Show resolved Hide resolved
vizro-ai/docs/pages/user_guides/run_vizro_ai.md Outdated Show resolved Hide resolved
vizro-ai/src/vizro_ai/_vizro_ai.py Outdated Show resolved Hide resolved
maxschulz-COL
maxschulz-COL approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Anna-Xiong Anna-Xiong merged commit 674ef58 into main Jan 11, 2024
33 checks passed
@Anna-Xiong Anna-Xiong deleted the feat/add_max_retry_parameter branch January 11, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxschulz-COL maxschulz-COL maxschulz-COL approved these changes

@huong-li-nguyen huong-li-nguyen huong-li-nguyen approved these changes

@Joseph-Perkins Joseph-Perkins Awaiting requested review from Joseph-Perkins Joseph-Perkins is a code owner

@antonymilne antonymilne Awaiting requested review from antonymilne antonymilne is a code owner

Assignees

@Anna-Xiong Anna-Xiong

Labels
Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anna-Xiong @maxschulz-COL @huong-li-nguyen