-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyword explain
to private vizro-ai method
#256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxschulz-COL
added
Bug Report 🐛
Issue contains a bug report
Vizro-AI 🤖
Issue/PR that addresses Vizro-AI package
labels
Jan 9, 2024
for more information, see https://pre-commit.ci
maxschulz-COL
requested review from
Joseph-Perkins,
antonymilne and
huong-li-nguyen
as code owners
January 9, 2024 10:37
Anna-Xiong
requested changes
Jan 9, 2024
Anna-Xiong
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved already but we need to change it to True to get explanation otherwise it is none for explanation.
Co-authored-by: Anna Xiong <[email protected]> Signed-off-by: Maximilian Schulz <[email protected]>
for more information, see https://pre-commit.ci
huong-li-nguyen
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the docs example:
fails due to the keyword
explain
not being present.Given that users might want to extract the code, explanation and insights separately, it makes sense to allow this keyword AND to also allow the return of the entire dictionary containing the code string, explanation and insights (see updated docs example).
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":