Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change vizro-ai integration tests #231

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

maxschulz-COL
Copy link
Contributor

@maxschulz-COL maxschulz-COL commented Dec 20, 2023

Description

vizro-ai integration tests require an OpenAI secret. This raises a few problems:

Proposed solution:

  • only run workflows with secrets (currently only vizro-ai integration tests) only on merge to main, and once per week
  • this should safeguard against bugs, but make forked PRs smoother, and API costs lower

Some interesting links if we revisit this topic:

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@maxschulz-COL maxschulz-COL changed the title Change on for vizro-ai integration tests Change vizro-ai integration tests Dec 20, 2023
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, it looks good!

Remember we'll need to remove these from required jobs in the Github settings also I think?

@maxschulz-COL
Copy link
Contributor Author

Thanks for the quick fix, it looks good!

Remember we'll need to remove these from required jobs in the Github settings also I think?

I was holding out to see what happens :)

@maxschulz-COL maxschulz-COL merged commit 9827fc7 into main Dec 20, 2023
32 checks passed
@maxschulz-COL maxschulz-COL deleted the bug/adjust_vizro_ai_integration_tests branch December 20, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants