-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release of the custom actions #178
Conversation
vizro-core/src/vizro/actions/_callback_mapping/_callback_mapping_utils.py
Show resolved
Hide resolved
…able_custom_actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you very much @petar-qb!
Just small comments and questions on the code implementation, but all the tests cases look great so I'm happy that the behaviour is all as expected 👍 Really great work on the tests.
I want to review the documentation also so won't approve yet but no major changes needed on the code 👍
vizro-core/tests/unit/vizro/actions/test_filter_interaction_action.py
Outdated
Show resolved
Hide resolved
…able_custom_actions
…able_custom_actions
@antonymilne do you think we should use |
vizro-core/changelog.d/20231122_143116_petar_pejovic_enable_custom_actions.md
Outdated
Show resolved
Hide resolved
I see what you mean and considered this before and decided this is not a good idea. In fact we should do |
vizro-core/changelog.d/20231122_143116_petar_pejovic_enable_custom_actions.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some updates to the docs in f3ac937 - please can you check it's all good?
After that I think it would be great if we could also have a screenshot for both of the clickData
custom action examples, and let's move this to a new docs page like @Joseph-Perkins suggested.
I'll answer the remaining unresolved code conversations separately since they're very minor.
Thank you for all your work on this, it's amazing! 🙏
@antonymilne Thanks a lot on f3ac937 - Docs look much better now 📝 🤩. |
Description
Screenshot
Checklist
Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":