Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dash datatable #114

Merged
merged 99 commits into from
Oct 30, 2023
Merged

Enable dash datatable #114

merged 99 commits into from
Oct 30, 2023

Conversation

maxschulz-COL
Copy link
Contributor

@maxschulz-COL maxschulz-COL commented Oct 16, 2023

Description

  • Implementation of the vm.Table model, alongside the shipped standard table function
  • implementation of vizro.charts.tables.dash_data_table

Further refactorings include:

  • multiple abstractions of implementation specific details
  • correct typing for ModelID
  • moving theme update logic out of page model

Things to be added once implementation is agreed upon:

  • Unit tests
  • Documentation

EDIT

Main open questions - may not all need to be adressed in this PR:

EDIT 2
PR almost finished, tasks left to do:

  • correct place for ModelID
  • @nadijagraca removal of !important

Screenshot

Screenshot 2023-10-25 at 19 34 23

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added the PR number to the change description in the changelog fragment, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1)) (if applicable)
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@maxschulz-COL maxschulz-COL changed the title Feature/table component ms Enable dash datatable Oct 16, 2023
maxschulz-COL and others added 3 commits October 26, 2023 09:16
Co-authored-by: Li Nguyen <[email protected]>
Signed-off-by: Maximilian Schulz <[email protected]>
Co-authored-by: Li Nguyen <[email protected]>
Signed-off-by: Maximilian Schulz <[email protected]>
@petar-qb petar-qb mentioned this pull request Oct 26, 2023
15 tasks
Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic work Max 🚀. I just left one question below.

After reverting app.py, dashboard.yaml, pyproject.toml changes and after adding changelog file, I think the PR will be ready for merging.

vizro-core/tests/unit/vizro/tables/test_dash_table.py Outdated Show resolved Hide resolved
@huong-li-nguyen huong-li-nguyen added Feature Request 🤓 Issue contains a feature request and removed Stage: Technical Design 🎨 labels Oct 26, 2023
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy to approve this subject to some minor suggestions and reverting the changes to the demo app or whatever your intention is. I haven't tried out the latest incarnation of the code myself but looks like others have done so and checked the styling etc. 👍

Really amazing work overall - I know this wasn't easy and had lots of iteration but I think it turned out great! Definitely one for the new Highlights section in our changelog ✨ Very nice work on the docs and tests also 👍

In future let's try to avoid such big PRs with 100s of comments, which I know is mainly my fault for leaving so many comments and digressions and asking things to be reworked 😅 Sometimes it's hard to avoid these things or they just happen by accident I know, and I'm as guilty as anyone here, but let's be mindful of it next time and maybe work through it in a different way that's more manageable for everyone 🙂

vizro-core/docs/pages/user_guides/table.md Show resolved Hide resolved
vizro-core/docs/pages/user_guides/table.md Show resolved Hide resolved
vizro-core/docs/pages/user_guides/table.md Show resolved Hide resolved
vizro-core/docs/pages/user_guides/table.md Outdated Show resolved Hide resolved
vizro-core/docs/pages/user_guides/table.md Show resolved Hide resolved
vizro-core/src/vizro/models/types.py Outdated Show resolved Hide resolved
vizro-core/src/vizro/models/types.py Outdated Show resolved Hide resolved
vizro-core/src/vizro/tables/dash_table.py Show resolved Hide resolved
vizro-core/tests/unit/vizro/tables/test_dash_table.py Outdated Show resolved Hide resolved
vizro-core/tests/unit/vizro/tables/test_dash_table.py Outdated Show resolved Hide resolved
@l0uden
Copy link
Contributor

l0uden commented Oct 27, 2023

Dashboards in my tests can't start with this error:

    from ._components import Card, Graph, Table
  File "/home/circleci/.venv/vizro-qa/lib/python3.8/site-packages/vizro/models/_components/__init__.py", line 5, in <module>
TypeError: 'ABCMeta' object is not subscriptable

@maxschulz-COL maxschulz-COL merged commit 2e9ac08 into main Oct 30, 2023
@maxschulz-COL maxschulz-COL deleted the feature/table_component_MS branch October 30, 2023 13:41
This was referenced Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request 🤓 Issue contains a feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants