-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Check PyCafe is working with Vizro in CI #1023
Conversation
for more information, see https://pre-commit.ci
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2025-02-19 13:12:05 UTC Link: vizro-core/examples/dev/ Link: vizro-core/examples/scratch_dev |
…into feature/pycafe_CI_checks
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- tools/pycafe/create_pycafe_links.py: Evaluated as low risk
Comments suppressed due to low confidence (1)
tools/pycafe/pycafe_utils.py:53
- Add error handling to ensure the script doesn't fail if the app.py file is missing.
response = requests.get(f"{base_url}/app.py", timeout=10)
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for doing this! 🌟
Description
This PR does two things:
Note: As before, due to security reasons we can only run this script from main, hence I can only see if it works once we merge this. As always, there will likely be a bug - so expect a few follow up pushes to
main
....Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":