Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Check PyCafe is working with Vizro in CI #1023

Merged
merged 15 commits into from
Feb 19, 2025

Conversation

maxschulz-COL
Copy link
Contributor

@maxschulz-COL maxschulz-COL commented Feb 17, 2025

Description

This PR does two things:

  • refactor the PyCafe link creation file to be more flexible, ie splitting it into utils and a main script
  • adding a new CI step that checks that the PyCafe links are actually working

Note: As before, due to security reasons we can only run this script from main, hence I can only see if it works once we merge this. As always, there will likely be a bug - so expect a few follow up pushes to main....

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

Copy link
Contributor

github-actions bot commented Feb 17, 2025

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2025-02-19 13:12:05 UTC
Commit: 01405e2

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • tools/pycafe/create_pycafe_links.py: Evaluated as low risk
Comments suppressed due to low confidence (1)

tools/pycafe/pycafe_utils.py:53

  • Add error handling to ensure the script doesn't fail if the app.py file is missing.
response = requests.get(f"{base_url}/app.py", timeout=10)

Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for doing this! 🌟

@maxschulz-COL maxschulz-COL merged commit 33dd93a into main Feb 19, 2025
37 checks passed
@maxschulz-COL maxschulz-COL deleted the feature/pycafe_CI_checks branch February 19, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants