Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy; Docs] Remove kedro _get_dataset call; enhance kedro docs #1014

Merged
merged 7 commits into from
Feb 14, 2025

Conversation

antonymilne
Copy link
Contributor

Description

  • Remove the _get_dataset call (only done for kedro>=0.19.9 even though we could maybe do it for some earlier versions. So the legacy code will remain for some time, but in future we now have a much better way to handle the data catalog that doesn't require any hacking 🎉 Thanks kedro team!)
  • Update data manager docs to fully explain the use of catalog.yaml as a data source registry outside a kedro project and expand on some other details that weren't explained before (I hope this is still intended use of DataCatalog @astrojuanlu? It was never very commonly done even though kedro had always designed it to be used like this)

FYI @astrojuanlu @gtauzin

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

Copy link
Contributor

github-actions bot commented Feb 12, 2025

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2025-02-14 16:04:04 UTC
Commit: f1510aa

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

@antonymilne antonymilne changed the title [Docs] Remove _get_dataset call and enhance kedro docs [Tidy; Docs] Remove kedro _get_dataset call; enhance kedro docs Feb 12, 2025
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs perspective. Just a few language tweaks because I thought we could make a complex topic slightly simpler, but really, I don't think any add much, so feel free to ignore.

@antonymilne antonymilne requested a review from gtauzin February 14, 2025 15:25
@antonymilne
Copy link
Contributor Author

Thanks for the review @stichbury! I've incorporated your suggestions.

@gtauzin I just updated the docs and our tests to use OmegaConfigLoader. Take a look: ef6db1c and built docs.

If you have a chance to look at it and think it looks good then please do try to click the Approve button 🙂

Copy link
Contributor

@gtauzin gtauzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements! Really like the way you advocate the use of the kedro catalog to non-kedro users.

@antonymilne antonymilne merged commit 913436d into main Feb 14, 2025
37 checks passed
@antonymilne antonymilne deleted the tidy/kedro branch February 14, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants