-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy; Docs] Remove kedro _get_dataset call; enhance kedro docs #1014
Conversation
for more information, see https://pre-commit.ci
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2025-02-14 16:04:04 UTC Link: vizro-core/examples/dev/ Link: vizro-core/examples/scratch_dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a docs perspective. Just a few language tweaks because I thought we could make a complex topic slightly simpler, but really, I don't think any add much, so feel free to ignore.
Co-authored-by: Jo Stichbury <[email protected]>
Thanks for the review @stichbury! I've incorporated your suggestions. @gtauzin I just updated the docs and our tests to use If you have a chance to look at it and think it looks good then please do try to click the Approve button 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements! Really like the way you advocate the use of the kedro catalog to non-kedro users.
Description
_get_dataset
call (only done forkedro>=0.19.9
even though we could maybe do it for some earlier versions. So the legacy code will remain for some time, but in future we now have a much better way to handle the data catalog that doesn't require any hacking 🎉 Thanks kedro team!)catalog.yaml
as a data source registry outside a kedro project and expand on some other details that weren't explained before (I hope this is still intended use ofDataCatalog
@astrojuanlu? It was never very commonly done even though kedro had always designed it to be used like this)FYI @astrojuanlu @gtauzin
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":