Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into qa/convert_warnings_into_errors
Browse files Browse the repository at this point in the history
huong-li-nguyen committed Dec 14, 2023
2 parents cff8960 + 0ad2b83 commit ec96e08
Showing 9 changed files with 50 additions and 22 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/checks-vizro-ai.yml
Original file line number Diff line number Diff line change
@@ -15,9 +15,6 @@ on:
paths:
- "vizro-ai/**"

concurrency:
group: checks-ai-${{ github.head_ref }}

env:
PYTHONUNBUFFERED: 1
FORCE_COLOR: 1
3 changes: 0 additions & 3 deletions .github/workflows/checks-vizro-core.yml
Original file line number Diff line number Diff line change
@@ -15,9 +15,6 @@ on:
paths:
- "vizro-core/**"

concurrency:
group: checks-core-${{ github.head_ref }}

env:
PYTHONUNBUFFERED: 1
FORCE_COLOR: 1
3 changes: 0 additions & 3 deletions .github/workflows/lint-vizro-all.yml
Original file line number Diff line number Diff line change
@@ -11,9 +11,6 @@ on:
branches:
- main

concurrency:
group: lint-${{ github.head_ref }}

env:
PYTHONUNBUFFERED: 1
FORCE_COLOR: 1
3 changes: 0 additions & 3 deletions .github/workflows/test-integration-vizro-ai.yml
Original file line number Diff line number Diff line change
@@ -11,9 +11,6 @@ on:
branches:
- main

concurrency:
group: test-integration-${{ github.head_ref }}

env:
PYTHONUNBUFFERED: 1
FORCE_COLOR: 1
3 changes: 0 additions & 3 deletions .github/workflows/test-integration-vizro-core.yml
Original file line number Diff line number Diff line change
@@ -11,9 +11,6 @@ on:
branches:
- main

concurrency:
group: test-integration-${{ github.head_ref }}

env:
PYTHONUNBUFFERED: 1
FORCE_COLOR: 1
3 changes: 0 additions & 3 deletions .github/workflows/test-unit-vizro-ai.yml
Original file line number Diff line number Diff line change
@@ -11,9 +11,6 @@ on:
branches:
- main

concurrency:
group: test-unit-${{ github.head_ref }}

env:
PYTHONUNBUFFERED: 1
FORCE_COLOR: 1
3 changes: 0 additions & 3 deletions .github/workflows/test-unit-vizro-core.yml
Original file line number Diff line number Diff line change
@@ -11,9 +11,6 @@ on:
branches:
- main

concurrency:
group: test-unit-${{ github.head_ref }}

env:
PYTHONUNBUFFERED: 1
FORCE_COLOR: 1
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Highlights ✨
- A bullet item for the Highlights ✨ category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Removed
- A bullet item for the Removed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Added
- A bullet item for the Added category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Changed
- A bullet item for the Changed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Deprecated
- A bullet item for the Deprecated category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Fixed
- A bullet item for the Fixed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Security
- A bullet item for the Security category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
3 changes: 2 additions & 1 deletion vizro-core/tests/integration/test_examples.py
Original file line number Diff line number Diff line change
@@ -38,4 +38,5 @@ def dashboard(request, monkeypatch):
def test_dashboard(dash_duo, dashboard):
app = Vizro(assets_folder=Path(__file__).parents[2] / "examples/assets").build(dashboard).dash
dash_duo.start_server(app)
assert dash_duo.get_logs() == []
# TODO: resolve the problem with driver recognized as chrome-headless-shell instead of chrome
# assert dash_duo.get_logs() == []

0 comments on commit ec96e08

Please sign in to comment.