Fix vm.Slider and vm.RangeSlider to work with incorrect textual input

mckinsey · Nov 14, 2023 · e977fa0 · e977fa0
1 parent d0a27ce
commit e977fa0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/vizro-core/src/vizro/static/js/models/range_slider.js b/vizro-core/src/vizro/static/js/models/range_slider.js
@@ -21,6 +21,9 @@ export function _update_range_slider_values(
     trigger_id === `${self_data["id"]}_start_value` ||
     trigger_id === `${self_data["id"]}_end_value`
   ) {
+    if (isNaN(start) || isNaN(end)) {
+      return dash_clientside.no_update;
+    }
     [start_text_value, end_text_value] = [start, end];
   } else if (trigger_id === self_data["id"]) {
     [start_text_value, end_text_value] = [slider[0], slider[1]];

diff --git a/vizro-core/src/vizro/static/js/models/slider.js b/vizro-core/src/vizro/static/js/models/slider.js
@@ -7,6 +7,9 @@ export function _update_slider_values(start, slider, input_store, self_data) {
       dash_clientside.callback_context.triggered[0]["prop_id"].split(".")[0];
   }
   if (trigger_id === `${self_data["id"]}_text_value`) {
+    if (isNaN(start)) {
+      return dash_clientside.no_update;
+    }
     text_value = start;
   } else if (trigger_id === self_data["id"]) {
     text_value = slider;