Skip to content

Commit

Permalink
Remove comments
Browse files Browse the repository at this point in the history
  • Loading branch information
antonymilne committed Oct 25, 2023
1 parent 6700208 commit c1a92de
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 17 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/check-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,3 @@ jobs:
./../tools/version-bump.sh mckinsey vizro ${{ secrets.GITHUB_TOKEN }} \
${{needs.check-version.outputs.package_name}} \
${{needs.check-version.outputs.package_version}} release/version_bump_next_minor/${formatted_date}
# automate merging of this?
# why need lint here?
# does github release notes automatically? Why not scriv github-release?
2 changes: 1 addition & 1 deletion .github/workflows/lint-vizro-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
fetch-depth: ${{ github.event_name == 'pull_request' && 2 || 0 }} #why?
fetch-depth: ${{ github.event_name == 'pull_request' && 2 || 0 }}

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand Down
18 changes: 6 additions & 12 deletions vizro-core/hatch.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ matrix.python.features = [
{value = "kedro", if = ["3.8", "3.9", "3.10"]}
]

[envs.changelog]
dependencies = ["scriv"]
detached = true
scripts = {add = "scriv create --add"}

[envs.default]
dependencies = [
"devtools[pygments]",
Expand Down Expand Up @@ -37,19 +42,14 @@ cov-report = [
]
example = "cd examples/{args:default}; python app.py"
lint = "SKIP=gitleaks pre-commit run {args} --all-files"
post-release = [
"hatch version patch,dev",
"echo 'Raise a PR to bump to the new development version'"
] # No longer needed?

prep-release = [
"hatch version release",
"hatch run changelog:scriv collect --add",
"rm -rf schemas/*json",
"schema",
"hatch run lint || hatch run lint",
"hatch run changelog:add",
'echo "Now raise a PR to merge into main with title: Release of vizro-core $(hatch version)"',
'echo "Now raise a PR to merge into main with title: Release of vizro-core $(hatch version)"'
]
pypath = "python -c 'import sys; print(sys.executable)'"
schema = "python schemas/generate.py {args}"
Expand Down Expand Up @@ -80,12 +80,6 @@ dependencies = [
detached = true
scripts = {serve = "mkdocs serve"}

[envs.changelog]
dependencies = ["scriv"]
detached = true
scripts = {add = "scriv create --add"}


[publish.index]
disable = true

Expand Down

0 comments on commit c1a92de

Please sign in to comment.