Skip to content

Commit

Permalink
Minor comment change
Browse files Browse the repository at this point in the history
  • Loading branch information
petar-qb committed Nov 18, 2024
1 parent d1bd246 commit a89b8bf
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions vizro-core/src/vizro/actions/_actions_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,7 @@ def _get_modified_page_figures(
else:
figure_targets.append(target)

# Retrieving only figure_targets data_frames from _multi_load is not the best solution.
# In that way, we assume that Filter.targets are the subset of the action's targets. This works for the
# on_page_load, but will not work if targets are explicitly set.
# For example, in future, if Parameter is targeting only a single Filter.
# Get data_frames for all figure_targets and components that are targets of controls
_get_unfiltered_data_targets = list(set(figure_targets + control_targets_targets))

figure_targets_unfiltered_data: dict[ModelID, pd.DataFrame] = _get_unfiltered_data(
Expand Down

0 comments on commit a89b8bf

Please sign in to comment.