Skip to content

Commit

Permalink
PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
huong-li-nguyen committed Dec 15, 2023
1 parent 9465df8 commit a347573
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-integration-vizro-ai.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
hatch-env: all.py3.11
- python-version: "3.12"
hatch-env: all.py3.12
- python-version: "3.12"
- python-version: "3.11"
hatch-env: lower-bounds
label: lower bounds

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-integration-vizro-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
hatch-env: all.py3.11
- python-version: "3.12"
hatch-env: all.py3.12
- python-version: "3.12"
- python-version: "3.11"
hatch-env: lower-bounds
label: lower bounds

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-unit-vizro-ai.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
hatch-env: all.py3.11
- python-version: "3.12"
hatch-env: all.py3.12
- python-version: "3.12"
- python-version: "3.11"
hatch-env: lower-bounds
label: lower bounds

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-unit-vizro-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
hatch-env: all.py3.11
- python-version: "3.12"
hatch-env: all.py3.12
- python-version: "3.12"
- python-version: "3.11"
hatch-env: lower-bounds
label: lower bounds

Expand Down
2 changes: 1 addition & 1 deletion vizro-core/hatch.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ python = ["3.8", "3.9", "3.10", "3.11", "3.12"]
# exception, so it can't be filtered out by pytest's filterwarnings. Instead we need
# to modify sys.warnoptions upfront so that Kedro does not convert the warning to an
# exception.
PYTHONWARNINGS = "ignore:Kedro is not yet fully compatible"
PYTHONWARNINGS = 'ignore:Kedro is not yet fully compatible with this Python version'

[envs.changelog]
dependencies = ["scriv"]
Expand Down
3 changes: 2 additions & 1 deletion vizro-core/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ addopts = [
filterwarnings = [
"error",
# Ignore this warning here as it comes from pandas until pandas is made compatible with Python 3.12
"ignore:.*utcfromtimestamp:DeprecationWarning"
"ignore:.*utcfromtimestamp:DeprecationWarning",
"ignore:Kedro is not yet fully compatible with this Python version"
]
norecursedirs = ["tests/tests_utils", "tests/js"]
pythonpath = ["tests/tests_utils"]

0 comments on commit a347573

Please sign in to comment.